On Tuesday, March 19, 2024 7:32:47 AM EDT Daniel Brown wrote:
Possibly a naive question, and possibly seemingly trivial, but is there any good reason to return a “1” on success for cephadm host-maintenance enter and exit:
No, I doubt that was intentional. The function is written in a way that causes it to always exit non-zero, but that seems accidental to me. Can you please file a tracker issue (at https://tracker.ceph.com/projects/ orchestrator - category = "cephadm (binary)" ) to track this bug, please? This would be a very nice bugfix for any one looking to get started with contributing to cephadm. :-)
~$ sudo cephadm host-maintenance enter --fsid XXXX-XXXXXX-XXXX-XXXXX Inferring config /var/lib/ceph/XXXX-XXXXXX-XXXX-XXXXXconfig/ceph.conf Requested to place host into maintenance success - systemd target ceph-XXXX-XXXXXX-XXXX-XXXXX.target disabled ~$ echo $? 1
~$ sudo cephadm host-maintenance exit --fsidXXXX-XXXXXX-XXXX-XXXXX Inferring config /var/lib/ceph/XXXX-XXXXXX-XXXX-XXXXX /config/ceph.conf Requested to exit maintenance state success - systemd target ceph-XXXX-XXXXXX-XXXX-XXXXX .target enabled and started
~$ echo $?
1