Return value from cephadm host-maintenance?
Possibly a naive question, and possibly seemingly trivial, but is there any good reason to return a “1” on success for cephadm host-maintenance enter and exit: ~$ sudo cephadm host-maintenance enter --fsid XXXX-XXXXXX-XXXX-XXXXX Inferring config /var/lib/ceph/XXXX-XXXXXX-XXXX-XXXXXconfig/ceph.conf Requested to place host into maintenance success - systemd target ceph-XXXX-XXXXXX-XXXX-XXXXX.target disabled ~$ echo $? 1 ~$ sudo cephadm host-maintenance exit --fsidXXXX-XXXXXX-XXXX-XXXXX Inferring config /var/lib/ceph/XXXX-XXXXXX-XXXX-XXXXX /config/ceph.conf Requested to exit maintenance state success - systemd target ceph-XXXX-XXXXXX-XXXX-XXXXX .target enabled and started ~$ echo $? 1
On Tuesday, March 19, 2024 7:32:47 AM EDT Daniel Brown wrote:
Possibly a naive question, and possibly seemingly trivial, but is there any good reason to return a “1” on success for cephadm host-maintenance enter and exit:
No, I doubt that was intentional. The function is written in a way that causes it to always exit non-zero, but that seems accidental to me. Can you please file a tracker issue (at https://tracker.ceph.com/projects/ orchestrator - category = "cephadm (binary)" ) to track this bug, please? This would be a very nice bugfix for any one looking to get started with contributing to cephadm. :-)
~$ sudo cephadm host-maintenance enter --fsid XXXX-XXXXXX-XXXX-XXXXX Inferring config /var/lib/ceph/XXXX-XXXXXX-XXXX-XXXXXconfig/ceph.conf Requested to place host into maintenance success - systemd target ceph-XXXX-XXXXXX-XXXX-XXXXX.target disabled ~$ echo $? 1
~$ sudo cephadm host-maintenance exit --fsidXXXX-XXXXXX-XXXX-XXXXX Inferring config /var/lib/ceph/XXXX-XXXXXX-XXXX-XXXXX /config/ceph.conf Requested to exit maintenance state success - systemd target ceph-XXXX-XXXXXX-XXXX-XXXXX .target enabled and started
~$ echo $?
1
Assuming I need admin approval to report this on tracker, how long does it take to get approved?? Signed up a couple days ago, but still seeing “Your account was created and is now pending administrator approval.”
On Mar 19, 2024, at 7:51 AM, John Mulligan <phlogistonjohn@asynchrono.us> wrote:
On Tuesday, March 19, 2024 7:32:47 AM EDT Daniel Brown wrote:
Possibly a naive question, and possibly seemingly trivial, but is there any good reason to return a “1” on success for cephadm host-maintenance enter and exit:
No, I doubt that was intentional. The function is written in a way that causes it to always exit non-zero, but that seems accidental to me.
Can you please file a tracker issue (at https://tracker.ceph.com/projects/ orchestrator - category = "cephadm (binary)" ) to track this bug, please? This would be a very nice bugfix for any one looking to get started with contributing to cephadm. :-)
~$ sudo cephadm host-maintenance enter --fsid XXXX-XXXXXX-XXXX-XXXXX Inferring config /var/lib/ceph/XXXX-XXXXXX-XXXX-XXXXXconfig/ceph.conf Requested to place host into maintenance success - systemd target ceph-XXXX-XXXXXX-XXXX-XXXXX.target disabled ~$ echo $? 1
~$ sudo cephadm host-maintenance exit --fsidXXXX-XXXXXX-XXXX-XXXXX Inferring config /var/lib/ceph/XXXX-XXXXXX-XXXX-XXXXX /config/ceph.conf Requested to exit maintenance state success - systemd target ceph-XXXX-XXXXXX-XXXX-XXXXX .target enabled and started
~$ echo $?
1
On Thursday, March 21, 2024 11:43:19 AM EDT Daniel Brown wrote:
Assuming I need admin approval to report this on tracker, how long does it take to get approved?? Signed up a couple days ago, but still seeing “Your account was created and is now pending administrator approval.”
That's unfortunate. I pinged about your issue signing up on the ceph slack channel for infrastructure. Hopefully, that'll get somebody's attention. If you don't get access by tomorrow feel free to ping me again directly and then *I'll* file the issue for you instead of having you wait around more.
participants (2)
-
Daniel Brown
-
John Mulligan