One thing I should have noted: You'll need to make sure you've rebased on main, or done something else to ensure that you have the changes to ceph.git in https://github.com/ceph/ceph/pull/59868 (the new src/container directory and contents). Also, I forgot this would need backporting to prior releases, so I've just filed backport PRs for reef, squid, and quincy: https://github.com/ceph/ceph/pull/60228 https://github.com/ceph/ceph/pull/60229 https://github.com/ceph/ceph/pull/60230 ...and once those are merged, you may need to rebase your branch on the appropriate corresponding branch. Sorry for the oversight. On 10/8/2024 5:31 PM, Dan Mick wrote:
I've just merged https://github.com/ceph/ceph-build/pull/2280, which changes the ceph-dev-new family of Jenkins jobs (the jobs that build branches pushed to ceph-ci.git) to use code from ceph.git to build containers. Ideally all you should need to know about this is nothing; containers are still built for CI branches and pushed with the same tags as they always have been to quay.ceph.io. Of course there may be unforeseen bugs; if a build fails while building containers, and the failure is not clear, please contact me ASAP.
Details: Until today, a separate workspace, ceph-container.git, held the code for building Ceph containers. This code is complex and hard to understand and maintain, and supplies much more flexibility than we've ever used for Ceph. The newer strategy is much simpler, and will make container building much more understandable and maintainable, as well as keeping the container sources nearby the code they're used to package. ceph.git now has a container/ subdirectory that holds the parameterized Containerfile and a build script, build.sh. These changes to ceph-build change the Jenkins job to use those new files for building containers, independently from ceph-container.git.
Release containers are still handled by ceph-container.git, but that will also change soon.