teuthology is now python3
hi folks, we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2". which means: - we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch. if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP. currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5. the next step is to - drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport -- Regards Kefu Chai
This is sweet, Kefu, thanks for the great job you’ve done here. I honestly thought we can have py2 branch minimal and just rebase it regularly when something merged to the master. The backporting looks good to me too though, do we have a recommendation page, or should we create a devguide how to backport teuthology patches? Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany
On Apr 14, 2020, at 9:39 AM, kefu chai <tchaikov@gmail.com> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai _______________________________________________ Sepia mailing list -- sepia@ceph.io To unsubscribe send an email to sepia-leave@ceph.io
On Wed, Apr 15, 2020 at 12:39 AM Kyrylo Shatskyy <kyrylo.shatskyy@suse.com> wrote:
This is sweet,
Kefu, thanks for the great job you’ve done here.
thank you! just tried to help and to continue based on your ground work.
I honestly thought we can have py2 branch minimal and just rebase it regularly when something merged to the master.
i am trying to avoid using the word of "rebase". as i want to drop python3 support in master. to rebase python2 compatible branch on a python3 only branch sounds dangerous to me.
The backporting looks good to me too though, do we have a recommendation page, or should we create a devguide how to backport teuthology patches?
not yet. i have not got a chance to create one.
Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany
On Apr 14, 2020, at 9:39 AM, kefu chai <tchaikov@gmail.com> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai _______________________________________________ Sepia mailing list -- sepia@ceph.io To unsubscribe send an email to sepia-leave@ceph.io
-- Regards Kefu Chai
So we are clear about this any tests using a branch based on luminous, mimic, nautilus, or octopus should use "--teuthology-branch py2". Anything newer than octopus should be tested against the teuthology master branch (IOW do not use "--teuthology-branch py2"). Hope this is clear. On Tue, Apr 14, 2020 at 5:40 PM kefu chai <tchaikov@gmail.com> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai _______________________________________________ Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
-- Cheers, Brad
On Thu, Apr 23, 2020 at 9:59 PM Brad Hubbard <bhubbard@redhat.com> wrote:
So we are clear about this any tests using a branch based on luminous, mimic, nautilus, or octopus should use "--teuthology-branch py2".
Anything newer than octopus should be tested against the teuthology master branch (IOW do not use "--teuthology-branch py2").
Is there a way we can automate this? I guess the main users of older branches will probably be the nightlies or using backport scripts so maybe we're okay just leaving it, but something that checks the included tags and tries to guess or at least warn if you use the wrong one would prevent some errors. (I'm assuming this applies to anything we run with teuthology-schedule, not just direct invocations.) -Greg
Hope this is clear.
On Tue, Apr 14, 2020 at 5:40 PM kefu chai <tchaikov@gmail.com> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai _______________________________________________ Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
-- Cheers, Brad _______________________________________________ Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
On Sat, Apr 25, 2020 at 5:20 AM Gregory Farnum <gfarnum@redhat.com> wrote:
On Thu, Apr 23, 2020 at 9:59 PM Brad Hubbard <bhubbard@redhat.com> wrote:
So we are clear about this any tests using a branch based on luminous, mimic, nautilus, or octopus should use "--teuthology-branch py2".
Anything newer than octopus should be tested against the teuthology master branch (IOW do not use "--teuthology-branch py2").
Is there a way we can automate this?
I think to be effective it would have to reject the command line purely from the command line arguments given and I'm not sure there's a way to determine what branch a run is based on purely from the command line arguments with any great certainty unless we decide on a convention for branch naming that *always* includes the branch (or am I thinking about this the wrong way?).
I guess the main users of older branches will probably be the nightlies or using backport scripts so maybe we're okay just leaving it, but something that checks the included tags and tries to guess or at least warn if you use the wrong one would prevent some errors.
(I'm assuming this applies to anything we run with teuthology-schedule, not just direct invocations.)
Yes.
-Greg
Hope this is clear.
On Tue, Apr 14, 2020 at 5:40 PM kefu chai <tchaikov@gmail.com> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai _______________________________________________ Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
-- Cheers, Brad _______________________________________________ Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
-- Cheers, Brad
Comments below. Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany On May 13, 2020, at 9:00 AM, Brad Hubbard <bhubbard@redhat.com<mailto:bhubbard@redhat.com>> wrote: On Sat, Apr 25, 2020 at 5:20 AM Gregory Farnum <gfarnum@redhat.com<mailto:gfarnum@redhat.com>> wrote: On Thu, Apr 23, 2020 at 9:59 PM Brad Hubbard <bhubbard@redhat.com<mailto:bhubbard@redhat.com>> wrote: So we are clear about this any tests using a branch based on luminous, mimic, nautilus, or octopus should use "--teuthology-branch py2". Anything newer than octopus should be tested against the teuthology master branch (IOW do not use "--teuthology-branch py2"). Is there a way we can automate this? One of the idea I have in mind is: 1) submit to ceph branches which are py3 ready a config file for example .ci or .teuthology, which will include: teuthology_branch: master 2) the teuthology.suite should be patched to read this file from the local copy of ceph or suite repo, if the —teuthology-branch is not provided, use teuthology_branch value from it. 3) if corresponding config file missing in the target repos and no option is given, teuthology can take default value from teuthology_config which we need to set to "py2" I think to be effective it would have to reject the command line purely from the command line arguments given and I'm not sure there's a way to determine what branch a run is based on purely from the command line arguments with any great certainty unless we decide on a convention for branch naming that *always* includes the branch (or am I thinking about this the wrong way?). I guess the main users of older branches will probably be the nightlies or using backport scripts so maybe we're okay just leaving it, but something that checks the included tags and tries to guess or at least warn if you use the wrong one would prevent some errors. (I'm assuming this applies to anything we run with teuthology-schedule, not just direct invocations.) Yes. -Greg Hope this is clear. On Tue, Apr 14, 2020 at 5:40 PM kefu chai <tchaikov@gmail.com<mailto:tchaikov@gmail.com>> wrote: hi folks, we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2". which means: - we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch. if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP. currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5. the next step is to - drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport -- Regards Kefu Chai _______________________________________________ Dev mailing list -- dev@ceph.io<mailto:dev@ceph.io> To unsubscribe send an email to dev-leave@ceph.io<mailto:dev-leave@ceph.io> -- Cheers, Brad _______________________________________________ Dev mailing list -- dev@ceph.io<mailto:dev@ceph.io> To unsubscribe send an email to dev-leave@ceph.io<mailto:dev-leave@ceph.io> -- Cheers, Brad
On Wed, May 20, 2020 at 4:38 PM Kyrylo Shatskyy <kyrylo.shatskyy@suse.com> wrote:
One of the idea I have in mind is: 1) submit to ceph branches which are py3 ready a config file for example .ci or .teuthology, which will include: teuthology_branch: master 2) the teuthology.suite should be patched to read this file from the local copy of ceph or suite repo, if the —teuthology-branch is not provided, use teuthology_branch value from it.
We want to make sure we read the file from the branch we schedule against, which may not be the local one. Otherwise this makes sense to me. (We could also put the file in the qa directory to avoid polluting our root.)
3) if corresponding config file missing in the target repos and no option is given, teuthology can take default value from teuthology_config which we need to set to "py2"
Gregory, https://github.com/ceph/teuthology/pull/1490 Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany
On May 21, 2020, at 9:42 PM, Gregory Farnum <gfarnum@redhat.com> wrote:
On Wed, May 20, 2020 at 4:38 PM Kyrylo Shatskyy <kyrylo.shatskyy@suse.com> wrote:
One of the idea I have in mind is: 1) submit to ceph branches which are py3 ready a config file for example .ci or .teuthology, which will include: teuthology_branch: master 2) the teuthology.suite should be patched to read this file from the local copy of ceph or suite repo, if the —teuthology-branch is not provided, use teuthology_branch value from it.
We want to make sure we read the file from the branch we schedule against, which may not be the local one.
Otherwise this makes sense to me. (We could also put the file in the qa directory to avoid polluting our root.)
3) if corresponding config file missing in the target repos and no option is given, teuthology can take default value from teuthology_config which we need to set to "py2"
Sepia mailing list -- sepia@ceph.io To unsubscribe send an email to sepia-leave@ceph.io
hi folks, nautilus's qa/ is now py3 compatible now. so the only release branch which needs the "--teuthology-branch py2" option is now octopus. and i am working on backporting py3 changes to it. please stay tuned. On Tue, Apr 14, 2020 at 3:39 PM kefu chai <tchaikov@gmail.com> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai
-- Regards Kefu Chai
Wait, I thought the default teuthology_branch was py2 now. See https://github.com/ceph/teuthology/pull/1490#issuecomment-637624786 and below On 6/3/20 11:25 AM, kefu chai wrote:
hi folks,
nautilus's qa/ is now py3 compatible now. so the only release branch which needs the "--teuthology-branch py2" option is now octopus. and i am working on backporting py3 changes to it. please stay tuned.
On Tue, Apr 14, 2020 at 3:39 PM kefu chai <tchaikov@gmail.com> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai
Le mer. 3 juin 2020 à 23:29, David Galloway <dgallowa@redhat.com> a écrit :
Wait, I thought the default teuthology_branch was py2 now.
See https://github.com/ceph/teuthology/pull/1490#issuecomment-637624786 and below
David, could you help create a PR backporting the master change to nautilus?
On 6/3/20 11:25 AM, kefu chai wrote:
hi folks,
nautilus's qa/ is now py3 compatible now. so the only release branch which needs the "--teuthology-branch py2" option is now octopus. and i am working on backporting py3 changes to it. please stay tuned.
On Tue, Apr 14, 2020 at 3:39 PM kefu chai <tchaikov@gmail.com> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai
--
Regards Kefu Chai
On 6/3/20 11:51 AM, kefu chai wrote:
Le mer. 3 juin 2020 à 23:29, David Galloway <dgallowa@redhat.com <mailto:dgallowa@redhat.com>> a écrit :
Wait, I thought the default teuthology_branch was py2 now.
See https://github.com/ceph/teuthology/pull/1490#issuecomment-637624786 and below
David, could you help create a PR backporting the master change to nautilus?
Never done it before but I think I followed the doc sufficiently? https://github.com/ceph/ceph/pull/35369
On 6/3/20 11:25 AM, kefu chai wrote: > hi folks, > > nautilus's qa/ is now py3 compatible now. so the only release branch > which needs the "--teuthology-branch py2" option is now octopus. and i > am working on backporting py3 changes to it. please stay tuned. > > On Tue, Apr 14, 2020 at 3:39 PM kefu chai <tchaikov@gmail.com <mailto:tchaikov@gmail.com>> wrote: >> >> hi folks, >> >> we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph >> to python3. and from now on, the teuthology-worker runs in a python3 >> environment by default unless specified otherwise using >> "--teuthology-branch py2". >> >> which means: >> >> - we need to write tests in python3 in master now >> - teuthology should be python3 compatible. >> - teuthology bug fixes should be backported to "py2" branch. >> >> if you run into any issues related to python3 due to the above >> changes, please let me know. and i will try to fix it ASAP. >> >> currently, the tests under qa/ directories in ceph:ceph master branch >> are python2 and python3 compatible. but since we've moved to python3, >> there is no need to be python2 compatible anymore. since the sepia lab >> is still using ubuntu xenial, we cannot use features offered by >> python3.6 at this moment yet. but we do plan to upgrade the OS to >> bionic soon. before that happens, the tests need to be compatible with >> Python3.5. >> >> the next step is to >> >> - drop python2 support in ceph:ceph master branch, and >> - drop python2 support in ceph:teuthology master. >> - backport python3 compatible changes to octopus and nautilus to ease >> the pain of backport >> >> -- >> Regards >> Kefu Chai > > >
-- Regards Kefu Chai
Great news, Thanks Kefu for finishing this huge effort. Btw, the crontab should be updated to remove -t py2. Yuri, could you please help? Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany
On Jun 3, 2020, at 9:18 PM, David Galloway <dgallowa@redhat.com> wrote:
On 6/3/20 11:51 AM, kefu chai wrote:
Le mer. 3 juin 2020 à 23:29, David Galloway <dgallowa@redhat.com <mailto:dgallowa@redhat.com>> a écrit :
Wait, I thought the default teuthology_branch was py2 now.
See https://github.com/ceph/teuthology/pull/1490#issuecomment-637624786 and below
David, could you help create a PR backporting the master change to nautilus?
Never done it before but I think I followed the doc sufficiently?
https://github.com/ceph/ceph/pull/35369
On 6/3/20 11:25 AM, kefu chai wrote:
hi folks,
nautilus's qa/ is now py3 compatible now. so the only release branch which needs the "--teuthology-branch py2" option is now octopus. and i am working on backporting py3 changes to it. please stay tuned.
On Tue, Apr 14, 2020 at 3:39 PM kefu chai <tchaikov@gmail.com <mailto:tchaikov@gmail.com>> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the
sepia lab
is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai
-- Regards Kefu Chai
_______________________________________________ Sepia mailing list -- sepia@ceph.io To unsubscribe send an email to sepia-leave@ceph.io
Kefu has done that https://github.com/ceph/ceph/pull/35363 and we still need py2 for octopus On Wed, Jun 3, 2020 at 1:57 PM Kyrylo Shatskyy <kyrylo.shatskyy@suse.com> wrote:
Great news,
Thanks Kefu for finishing this huge effort.
Btw, the crontab should be updated to remove -t py2. Yuri, could you please help?
Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany
On Jun 3, 2020, at 9:18 PM, David Galloway <dgallowa@redhat.com> wrote:
On 6/3/20 11:51 AM, kefu chai wrote:
Le mer. 3 juin 2020 à 23:29, David Galloway <dgallowa@redhat.com <mailto:dgallowa@redhat.com>> a écrit :
Wait, I thought the default teuthology_branch was py2 now.
See https://github.com/ceph/teuthology/pull/1490#issuecomment-637624786 and below
David, could you help create a PR backporting the master change to nautilus?
Never done it before but I think I followed the doc sufficiently?
https://github.com/ceph/ceph/pull/35369
On 6/3/20 11:25 AM, kefu chai wrote:
hi folks,
nautilus's qa/ is now py3 compatible now. so the only release branch which needs the "--teuthology-branch py2" option is now octopus. and i am working on backporting py3 changes to it. please stay tuned.
On Tue, Apr 14, 2020 at 3:39 PM kefu chai <tchaikov@gmail.com <mailto:tchaikov@gmail.com>> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the
sepia lab
is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai
-- Regards Kefu Chai
_______________________________________________ Sepia mailing list -- sepia@ceph.io To unsubscribe send an email to sepia-leave@ceph.io
_______________________________________________ Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
Oh, this is nice, but l can see there `-t py2` for octopus in qa/machine_types/schedule_subset.sh<https://github.com/ceph/ceph/pull/35363#diff-de802ac94d30f3bfc1a4dc7e2e66b323> Because we merged the https://github.com/ceph/teuthology/pull/1490 there is no need in exclusive -t option. Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany On Jun 3, 2020, at 11:01 PM, Yuri Weinstein <yweinste@redhat.com<mailto:yweinste@redhat.com>> wrote: Kefu has done that https://github.com/ceph/ceph/pull/35363 and we still need py2 for octopus On Wed, Jun 3, 2020 at 1:57 PM Kyrylo Shatskyy <kyrylo.shatskyy@suse.com<mailto:kyrylo.shatskyy@suse.com>> wrote: Great news, Thanks Kefu for finishing this huge effort. Btw, the crontab should be updated to remove -t py2. Yuri, could you please help? Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany On Jun 3, 2020, at 9:18 PM, David Galloway <dgallowa@redhat.com<mailto:dgallowa@redhat.com>> wrote: On 6/3/20 11:51 AM, kefu chai wrote: Le mer. 3 juin 2020 à 23:29, David Galloway <dgallowa@redhat.com<mailto:dgallowa@redhat.com> <mailto:dgallowa@redhat.com>> a écrit : Wait, I thought the default teuthology_branch was py2 now. See https://github.com/ceph/teuthology/pull/1490#issuecomment-637624786 and below David, could you help create a PR backporting the master change to nautilus? Never done it before but I think I followed the doc sufficiently? https://github.com/ceph/ceph/pull/35369 On 6/3/20 11:25 AM, kefu chai wrote: hi folks, nautilus's qa/ is now py3 compatible now. so the only release branch which needs the "--teuthology-branch py2" option is now octopus. and i am working on backporting py3 changes to it. please stay tuned. On Tue, Apr 14, 2020 at 3:39 PM kefu chai <tchaikov@gmail.com <mailto:tchaikov@gmail.com>> wrote: hi folks, we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2". which means: - we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch. if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP. currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5. the next step is to - drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport -- Regards Kefu Chai -- Regards Kefu Chai _______________________________________________ Sepia mailing list -- sepia@ceph.io To unsubscribe send an email to sepia-leave@ceph.io _______________________________________________ Dev mailing list -- dev@ceph.io<mailto:dev@ceph.io> To unsubscribe send an email to dev-leave@ceph.io<mailto:dev-leave@ceph.io> _______________________________________________ Sepia mailing list -- sepia@ceph.io<mailto:sepia@ceph.io> To unsubscribe send an email to sepia-leave@ceph.io<mailto:sepia-leave@ceph.io>
Here is PR for octopus https://github.com/ceph/ceph/pull/35371 I let you and Kefu merge it . On Wed, Jun 3, 2020 at 2:15 PM Kyrylo Shatskyy <kyrylo.shatskyy@suse.com> wrote:
Oh, this is nice, but l can see there `-t py2` for octopus in qa/machine_types/schedule_subset.sh Because we merged the https://github.com/ceph/teuthology/pull/1490 there is no need in exclusive -t option.
Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany
On Jun 3, 2020, at 11:01 PM, Yuri Weinstein <yweinste@redhat.com> wrote:
Kefu has done that https://github.com/ceph/ceph/pull/35363 and we still need py2 for octopus
On Wed, Jun 3, 2020 at 1:57 PM Kyrylo Shatskyy <kyrylo.shatskyy@suse.com> wrote:
Great news,
Thanks Kefu for finishing this huge effort.
Btw, the crontab should be updated to remove -t py2. Yuri, could you please help?
Kyrylo Shatskyy -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nuremberg Germany
On Jun 3, 2020, at 9:18 PM, David Galloway <dgallowa@redhat.com> wrote:
On 6/3/20 11:51 AM, kefu chai wrote:
Le mer. 3 juin 2020 à 23:29, David Galloway <dgallowa@redhat.com <mailto:dgallowa@redhat.com>> a écrit :
Wait, I thought the default teuthology_branch was py2 now.
See https://github.com/ceph/teuthology/pull/1490#issuecomment-637624786 and below
David, could you help create a PR backporting the master change to nautilus?
Never done it before but I think I followed the doc sufficiently?
https://github.com/ceph/ceph/pull/35369
On 6/3/20 11:25 AM, kefu chai wrote:
hi folks,
nautilus's qa/ is now py3 compatible now. so the only release branch which needs the "--teuthology-branch py2" option is now octopus. and i am working on backporting py3 changes to it. please stay tuned.
On Tue, Apr 14, 2020 at 3:39 PM kefu chai <tchaikov@gmail.com
<mailto:tchaikov@gmail.com>> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the
sepia lab
is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible
with
Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai
-- Regards Kefu Chai
_______________________________________________ Sepia mailing list -- sepia@ceph.io To unsubscribe send an email to sepia-leave@ceph.io
_______________________________________________ Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
_______________________________________________ Sepia mailing list -- sepia@ceph.io To unsubscribe send an email to sepia-leave@ceph.io
hi folks, octopus' qa/ is py3 compatible now. so far, all currently maintained LTS branches' qa suites are python3 compatible. no need to pass "--teuthology-branch py2" to teuthology-suite anymore unless some test failure is suspicious. but, i think it should be safe to drop the python2 support at least in master without worrying the backport overhead now. cheers, On Wed, Jun 3, 2020 at 11:25 PM kefu chai <tchaikov@gmail.com> wrote:
hi folks,
nautilus's qa/ is now py3 compatible now. so the only release branch which needs the "--teuthology-branch py2" option is now octopus. and i am working on backporting py3 changes to it. please stay tuned.
On Tue, Apr 14, 2020 at 3:39 PM kefu chai <tchaikov@gmail.com> wrote:
hi folks,
we just migrated ceph:teuthology and all tests under qa/ in ceph:ceph to python3. and from now on, the teuthology-worker runs in a python3 environment by default unless specified otherwise using "--teuthology-branch py2".
which means:
- we need to write tests in python3 in master now - teuthology should be python3 compatible. - teuthology bug fixes should be backported to "py2" branch.
if you run into any issues related to python3 due to the above changes, please let me know. and i will try to fix it ASAP.
currently, the tests under qa/ directories in ceph:ceph master branch are python2 and python3 compatible. but since we've moved to python3, there is no need to be python2 compatible anymore. since the sepia lab is still using ubuntu xenial, we cannot use features offered by python3.6 at this moment yet. but we do plan to upgrade the OS to bionic soon. before that happens, the tests need to be compatible with Python3.5.
the next step is to
- drop python2 support in ceph:ceph master branch, and - drop python2 support in ceph:teuthology master. - backport python3 compatible changes to octopus and nautilus to ease the pain of backport
-- Regards Kefu Chai
-- Regards Kefu Chai
-- Regards Kefu Chai
Hi Kefu, On Mon, Jun 15, 2020 at 6:31 PM kefu chai <tchaikov@gmail.com> wrote:
octopus' qa/ is py3 compatible now. so far, all currently maintained LTS branches' qa suites are python3 compatible. no need to pass "--teuthology-branch py2" to teuthology-suite anymore unless some test failure is suspicious.
So I take it we're running all teuthology tests on Octopus with py3, right? Do we need to still maintain python2 compatibility going forward? I just ran into this failure: Traceback (most recent call last): File "../qa/tasks/vstart_runner.py", line 130, in <module> from tasks.cephfs.fuse_mount import FuseMount File "/tmp/tmp.HVEkHktXc3/venv/local/lib/python2.7/site-packages/gevent/builtins.py", line 96, in __import__ result = _import(*args, **kwargs) File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/cephfs/fuse_mount.py", line 15, in <module> from tasks.cephfs.mount import CephFSMount File "/tmp/tmp.HVEkHktXc3/venv/local/lib/python2.7/site-packages/gevent/builtins.py", line 96, in __import__ result = _import(*args, **kwargs) File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/cephfs/mount.py", line 201 return self.run_shell(["bash", "-c", Raw(f"'{payload}'")], **kwargs) ^ SyntaxError: invalid syntax https://github.com/ceph/ceph/pull/35759 https://jenkins.ceph.com/job/ceph-dashboard-pr-backend/2383/consoleFull#8423... I guess we're still using py2 in jenkins. Does that need changed? -- Patrick Donnelly, Ph.D. He / Him / His Senior Software Engineer Red Hat Sunnyvale, CA GPG: 19F28A586F808C2402351B93C3301A3E258DD79D
On Sat, Jun 27, 2020 at 7:08 AM Patrick Donnelly <pdonnell@redhat.com> wrote:
Hi Kefu,
On Mon, Jun 15, 2020 at 6:31 PM kefu chai <tchaikov@gmail.com> wrote:
octopus' qa/ is py3 compatible now. so far, all currently maintained LTS branches' qa suites are python3 compatible. no need to pass "--teuthology-branch py2" to teuthology-suite anymore unless some test failure is suspicious.
So I take it we're running all teuthology tests on Octopus with py3, right?
right.
Do we need to still maintain python2 compatibility going forward? I just ran into this failure:
no, i don't think so.
Traceback (most recent call last): File "../qa/tasks/vstart_runner.py", line 130, in <module> from tasks.cephfs.fuse_mount import FuseMount File "/tmp/tmp.HVEkHktXc3/venv/local/lib/python2.7/site-packages/gevent/builtins.py", line 96, in __import__ result = _import(*args, **kwargs) File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/cephfs/fuse_mount.py", line 15, in <module> from tasks.cephfs.mount import CephFSMount File "/tmp/tmp.HVEkHktXc3/venv/local/lib/python2.7/site-packages/gevent/builtins.py", line 96, in __import__ result = _import(*args, **kwargs) File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/cephfs/mount.py", line 201 return self.run_shell(["bash", "-c", Raw(f"'{payload}'")], **kwargs) ^ SyntaxError: invalid syntax
https://github.com/ceph/ceph/pull/35759 https://jenkins.ceph.com/job/ceph-dashboard-pr-backend/2383/consoleFull#8423...
I guess we're still using py2 in jenkins. Does that need changed?
i think so. see https://github.com/ceph/ceph/pull/35809
-- Patrick Donnelly, Ph.D. He / Him / His Senior Software Engineer Red Hat Sunnyvale, CA GPG: 19F28A586F808C2402351B93C3301A3E258DD79D
-- Regards Kefu Chai
participants (7)
-
Brad Hubbard
-
David Galloway
-
Gregory Farnum
-
kefu chai
-
Kyrylo Shatskyy
-
Patrick Donnelly
-
Yuri Weinstein