13 Nov
2020
13 Nov
'20
8:26 p.m.
Great thx !
Any chance we can automatically add labels which would indicate what
suites are required to run in order to test them ?
On Fri, Nov 13, 2020 at 11:22 AM Josh Durgin <jdurgin(a)redhat.com> wrote:
Great work Ernesto! This will be an excellent building block for further
CI automation.
Josh
On 11/13/20 10:51 AM, Ernesto Puerta wrote:
Hi all,
Kefu & I have just merged these PRs [1] that enable a Github Action to
automatically label PRs based on matching paths in the changeset
(minimatch syntax) [2]. The file where to specify such mappings is
.github/labeler.yml
<https://github.com/ceph/ceph/blob/master/.github/labeler.yml>:
dashboard:
- src/pybind/mgr/dashboard/**
- qa/suites/rados/dashboard/**
- qa/tasks/mgr/test_dashboard.py ...
In this PoC, I only added the 'dashboard' and 'CI' labels, but I'd
encourage other teams to do the same with your own subdirs, and get rid,
as much as possible, of this repetitive task of manually setting labels.
This is an example of how this GH action tagged a PR [3] with the
dashboard label:
image.png
In the long term we could explore how to generate/use both CODEOWNERS
and labeler.yml files from the same source, as there's high redundancy
between both (but not all teams have a Github team).
[1] https://github.com/ceph/ceph/pull/38049
<https://github.com/ceph/ceph/pull/38049> and
https://github.com/ceph/ceph/pull/38060
<https://github.com/ceph/ceph/pull/38060>
[2] https://github.com/isaacs/minimatch
<https://github.com/isaacs/minimatch>
[3] https://github.com/ceph/ceph/pull/38065
<https://github.com/ceph/ceph/pull/38065>
Kind Regards,
Ernesto Puerta
_______________________________________________
Dev mailing list -- dev(a)ceph.io
To unsubscribe send an email to dev-leave(a)ceph.io
_______________________________________________
Dev mailing list -- dev(a)ceph.io
To unsubscribe send an email to dev-leave(a)ceph.io