On Tue, Dec 15, 2020 at 11:57 AM Ernesto Puerta <epuertat(a)redhat.com> wrote:
Hi Patrick,
Are we already using this "ready-to-merge" label? What does it mean
exactly? That the PR is already QA'd and just
needs merged or that the
PR has no conflicts? In any case, it does not seem useful to me and
adds visual clutter to the label list.
Until recently we used that in the dashboard for highlighting PRs meeting
all requirements (checks, reviews, QA, etc). Using a green label helped
visually identify PRs:
[image: image.png]
I'm not sure if our label colours are always helping understand the status
of a PR:
[image: image.png]
We recently stopped using the 'ready-to-merge' label and we now use a
column in our project board <https://github.com/ceph/ceph/projects/6>:
[image: image.png]
So I have no issue with removing the ready-to-merge label & the automation
rule in that PR. Is that ok?
+1 for an RBD point-of-view. We go from "needs-qa" ->
"wip-XYZ-testing"
branch label -> to merged assuming the suite passes.
The following
comment will be added: "This pull request can no longer be
automatically merged: a rebase is needed and changes have to be manually
resolved".
When the PR is rebased, conflict solved and re-pushed:
The `needs-rebase` label will be automatically removed
(`ready-to-merge` label
won't be added back though)
Otherwise, a very useful change. Thanks for your efforts on it!
+1 on the thanks!
You're welcome!
Kind Regards,
Ernesto
--
Patrick Donnelly, Ph.D.
He / Him / His
Principal Software Engineer
Red Hat Sunnyvale, CA
GPG: 19F28A586F808C2402351B93C3301A3E258DD79D
_______________________________________________
Dev mailing list -- dev(a)ceph.io
To unsubscribe send an email to dev-leave(a)ceph.io
--
Jason