24 Dec
2019
24 Dec
'19
2:29 p.m.
+ dev ML
+ Patrick
On Mon, Dec 23, 2019 at 2:32 PM Jos Collin <jcollin(a)redhat.com> wrote:
Hi Kefu,
I've been working on [1] and I have created a wip PR [2]. I saw your patch [3], which
is being inherited by the MDS-MDS messaging classes now. So do you mean that from now
on-wards we need to inherit from SafeMessage class instead of the Message class?
Jos, this change originally comes from Patrick.
see the commit message below
This is an opt-in wrapper around Message inheritance
to prevent undesired get/put calls on the object.
please note, it's an opt-in wrapper, so it's not mandatory to use this
wrapper. the beauty of it is that it's convenient. but i think MDS is
moving to SafeMessage, see https://github.com/ceph/ceph/pull/31330 .
so i guess it'd be nice to follow this convention in MDS related
refractory. unless Patrick thinks otherwise.
In that case I need to update my patch [2] to have
MMDSOp inherit from SafeMessage instead. Please suggest.
[1] https://tracker.ceph.com/issues/41565
[2] https://github.com/ceph/ceph/pull/31726
[3] https://github.com/ceph/ceph/commit/f78bc1a8cb2e5149736ea050c63149ae9b30d8aa
Thanks,
Jos Collin