ceph-dencoder output has differences...

Hi Kefu Since a few days there is a difference in the output of bluestore_bdev_t in ceph-dencoder. And it looks like the buffer is eihter too long, or not properly zero-ed out. the encode/decode stuff has not been touched for a while. But if it uses the pre-initialized test-label, this work out oke. Dump_json actually also reports identical results. So I guess it is somewhere in other code that manages the buffers?? Suggestions as how to debug it? --WjW [~/master36] wjw(a)cephdev.digiware.nl> build/bin/ceph-dencoder type bluestore_bdev_label_t select_test 1 encode export /tmp/typ-yFISvjvgj [~/master36] wjw(a)cephdev.digiware.nl> hexdump -C !$ hexdump -C /tmp/typ-yFISvjvgj 00000000  62 6c 75 65 73 74 6f 72  65 20 62 6c 6f 63 6b 20 |bluestore block | 00000010  64 65 76 69 63 65 0a 30  30 30 30 30 30 30 30 2d |device.00000000-| 00000020  30 30 30 30 2d 30 30 30  30 2d 30 30 30 30 2d 30 |0000-0000-0000-0| 00000030  30 30 30 30 30 30 30 30  30 30 30 0a 02 01 28 00 |00000000000...(.| 00000040  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................| 00000050  00 00 70 74 03 04 00 00  00 00 00 00 00 00 00 00 |..pt............| 00000060  00 00 00 00 00 00 00 00  00 00 |..........| 0000006a [~/master36] wjw(a)cephdev.digiware.nl> build/bin/ceph-dencoder type bluestore_bdev_label_t select_test 1 encode decode encode export /tmp/typ-MjWXdCpzJ [~/master36] wjw(a)cephdev.digiware.nl> hexdump -C !$ hexdump -C /tmp/typ-MjWXdCpzJ 00000000  62 6c 75 65 73 74 6f 72  65 20 62 6c 6f 63 6b 20 |bluestore block | 00000010  64 65 76 69 63 65 0a 30  30 30 30 30 30 30 30 2d |device.00000000-| 00000020  30 30 30 30 2d 30 30 30  30 2d 30 30 30 30 2d 30 |0000-0000-0000-0| 00000030  30 30 30 30 30 30 30 30  30 30 30 0a 02 01 28 00 |00000000000...(.| 00000040  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................| 00000050  00 00 73 64 00 00 00 00  00 00 00 00 00 00 00 00 |..sd............| 00000060  00 00 00 00 00 00 00 00  00 00 |..........| 0000006a [~/master36] wjw(a)cephdev.digiware.nl> build/bin/ceph-dencoder type bluestore_bdev_label_t select_test 2 encode decode encode export /tmp/test [~/master36] wjw(a)cephdev.digiware.nl> hexdump -C /tmp/test 00000000  62 6c 75 65 73 74 6f 72  65 20 62 6c 6f 63 6b 20 |bluestore block | 00000010  64 65 76 69 63 65 0a 30  30 30 30 30 30 30 30 2d |device.00000000-| 00000020  30 30 30 30 2d 30 30 30  30 2d 30 30 30 30 2d 30 |0000-0000-0000-0| 00000030  30 30 30 30 30 30 30 30  30 30 30 0a 02 01 3b 00 |00000000000...;.| 00000040  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................| 00000050  00 00 7b 00 00 00 00 00  00 00 04 00 00 00 05 00 |..{.............| 00000060  00 00 05 00 00 00 66 61  6b 65 79 01 00 00 00 03 |......fakey.....| 00000070  00 00 00 66 6f 6f 03 00  00 00 62 61 72 |...foo....bar| 0000007d [~/master36] wjw(a)cephdev.digiware.nl> build/bin/ceph-dencoder type bluestore_bdev_label_t select_test 2 encode export /tmp/test2 [~/master36] wjw(a)cephdev.digiware.nl> hexdump -C /tmp/test2 00000000  62 6c 75 65 73 74 6f 72  65 20 62 6c 6f 63 6b 20 |bluestore block | 00000010  64 65 76 69 63 65 0a 30  30 30 30 30 30 30 30 2d |device.00000000-| 00000020  30 30 30 30 2d 30 30 30  30 2d 30 30 30 30 2d 30 |0000-0000-0000-0| 00000030  30 30 30 30 30 30 30 30  30 30 30 0a 02 01 3b 00 |00000000000...;.| 00000040  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................| 00000050  00 00 7b 00 00 00 00 00  00 00 04 00 00 00 05 00 |..{.............| 00000060  00 00 05 00 00 00 66 61  6b 65 79 01 00 00 00 03 |......fakey.....| 00000070  00 00 00 66 6f 6f 03 00  00 00 62 61 72 |...foo....bar| 0000007d