Some tests: If in Nautilus 16.2.14 in /usr/lib/python3.6/site-packages/ceph_volume/util/disk.py I disable lines 804 and 805 804 if get_file_contents(os.path.join(_sys_block_path, dev, 'removable')) == "1": 805 continue the command "ceph-volume inventory" works as in Octopus or Nautilus < 16.2.11: [ceph: root@mostha1 /]# ceph-volume inventory Device Path Size Device nodes rotates available Model name /dev/sdc 232.83 GB sdc True True SAMSUNG HE253GJ /dev/sda 232.83 GB sda True False SAMSUNG HE253GJ /dev/sdb 465.76 GB sdb True False WDC WD5003ABYX-1 but 1) "ceph orch device ls" still returns nothing. 2) I cannot zap the /dev/sdc device: [ceph: root@mostha1 /]# ceph orch device zap mostha1.legi.grenoble-inp.fr /dev/sdc --force Error EINVAL: Device path '/dev/sdc' not found on host 'mostha1.legi.grenoble-inp.fr' 3) I cannot manualy add the sdc device as an osd: [ceph: root@mostha1 /]# ceph orch daemon add osd mostha1.legi.grenoble-inp.fr:/dev/sdc Created no osd(s) on host mostha1.legi.grenoble-inp.fr; already created? Even is the device is present and unused: [ceph: root@mostha1 /]# lsblk NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT sda 8:0 1 232.9G 0 disk |-sda1 8:1 1 3.9G 0 part /rootfs/boot |-sda2 8:2 1 3.9G 0 part [SWAP] `-sda3 8:3 1 225G 0 part |-al8vg-rootvol 253:0 0 48.8G 0 lvm /rootfs |-al8vg-homevol 253:2 0 9.8G 0 lvm /rootfs/home |-al8vg-tmpvol 253:3 0 9.8G 0 lvm /rootfs/tmp `-al8vg-varvol 253:4 0 79.8G 0 lvm /rootfs/var sdb 8:16 1 465.8G 0 disk `-ceph--08827fdc--136e--4070--97e9--e5e8b3970766-osd--block--7dec1808--d6f4--4f90--ac74--75a4346e1df5 253:1 0 465.8G 0 lvm sdc 8:32 1 232.9G 0 disk Patrick Le 24/10/2023 à 13:38, Patrick Begou a écrit :
Hi Eugen,
Yes Eugen, all the devices /dev/sd[abc] have the removable flag set to 1. May be because they are hot-swappable hard drives.
I have contacted the commit author Zack Cerza and he asked me for some additional tests too this morning. I add him in copy to this mail.
Patrick
Le 24/10/2023 à 12:57, Eugen Block a écrit :
Hi,
just to confirm, could you check that the disk which is *not* discovered by 16.2.11 has a "removable" flag?
cat /sys/block/sdX/removable
I could reproduce it as well on a test machine with a USB thumb drive (live distro) which is excluded in 16.2.11 but is shown in 16.2.10. Although I'm not a developer I tried to understand what changes were made in https://github.com/ceph/ceph/pull/46375/files#diff-330f9319b0fe352dff0486f66... and there's this line:
if get_file_contents(os.path.join(_sys_block_path, dev, 'removable')) == "1": continue
The thumb drive is removable, of course, apparently that is filtered here.
Regards, Eugen
Zitat von Patrick Begou <Patrick.Begou@univ-grenoble-alpes.fr>:
Le 23/10/2023 à 03:04, 544463199@qq.com a écrit :
I think you can try to roll back this part of the python code and wait for your good news :)
Not so easy 😕
[root@e9865d9a7f41 ceph]# git revert 4fc6bc394dffaf3ad375ff29cbb0a3eb9e4dbefc Auto-merging src/ceph-volume/ceph_volume/tests/util/test_device.py CONFLICT (content): Merge conflict in src/ceph-volume/ceph_volume/tests/util/test_device.py Auto-merging src/ceph-volume/ceph_volume/util/device.py CONFLICT (content): Merge conflict in src/ceph-volume/ceph_volume/util/device.py Auto-merging src/ceph-volume/ceph_volume/util/disk.py CONFLICT (content): Merge conflict in src/ceph-volume/ceph_volume/util/disk.py error: could not revert 4fc6bc394df... ceph-volume: Optionally consume loop devices
Patrick _______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
_______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io