16 Apr
2025
16 Apr
'25
8:23 p.m.
On Wednesday, April 16, 2025 2:05:12 PM Eastern Daylight Time Alex wrote:
Hi. Any feedback on my pull request? Thanks, Alex.
Hi Alex, I'm not a maintainer of the ceph-ansible project. So I was not planning on reviewing it. That said the first change looks reasonable but I'm not sure about the merge commit and the commits after that. I would say it's up to the maintainers of cephadm-ansible to decide if they're ok with that. In projects I do help maintain I like to see "clean" PRs without merges and fixup commits in them. Good luck!