11 Mar
2020
11 Mar
'20
11:58 a.m.
Hi,
why rbd import diff from stdin sets rbd_concurrent_management_ops to 1?
https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/Import.cc#L39
https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/Import.cc#L740
Can you remove this limitation?
Thanks & Regards,
Marian
11 Mar
11 Mar
12:24 p.m.
On Wed, Mar 11, 2020 at 7:59 AM <marian.krucina(a)gmail.com> wrote:
Hi,
why rbd import diff from stdin sets rbd_concurrent_management_ops to 1?
https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/Import.cc#L39
https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/Import.cc#L740
Can you remove this limitation?
The code would need to be restructured a bit to support that, but
definitely feel free to submit a PR to remove that limitation.
Thanks & Regards,
Marian
_______________________________________________
Dev mailing list -- dev(a)ceph.io
To unsubscribe send an email to dev-leave(a)ceph.io
--
Jason
4:31 p.m.
What is different between read from stdin and file? I don't see any.
Is safe remove only the condition "fd == STDIN_FILENO" ?
Will data be ok?
On Wed, Mar 11, 2020 at 1:25 PM Jason Dillaman <jdillama(a)redhat.com> wrote:
On Wed, Mar 11, 2020 at 7:59 AM
<marian.krucina(a)gmail.com> wrote:
https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/Import.cc#L740
> Can you remove this limitation?
The code would need to be restructured a bit to support that, but
definitely feel free to submit a PR to remove that limitation.
> Thanks & Regards,
> Marian
> _______________________________________________
> Dev mailing list -- dev(a)ceph.io
> To unsubscribe send an email to dev-leave(a)ceph.io
--
Jason
Hi,
why rbd import diff from stdin sets rbd_concurrent_management_ops to 1?
https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/Import.cc#L39
6:06 p.m.
On Wed, Mar 11, 2020 at 12:31 PM Marian Krucina
<marian.krucina(a)gmail.com> wrote:
What is different between read from stdin and file? I don't see any.
Is safe remove only the condition "fd == STDIN_FILENO" ?
Will data be ok?
Yes, I believe you can just drop the special casing for the max number
of ops if "fd == STDIN_FILENO". You'll need to keep the other special
cases for avoiding seeks and resizing the image (since we won't know
the final size until we are done).
On Wed, Mar 11, 2020 at 1:25 PM Jason Dillaman
<jdillama(a)redhat.com> wrote:
>
> On Wed, Mar 11, 2020 at 7:59 AM <marian.krucina(a)gmail.com> wrote:
> >
> > Hi,
> >
> > why rbd import diff from stdin sets rbd_concurrent_management_ops to 1?
> >
> > https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/Import.cc#L39
> > https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/Import.cc#L740
> >
> > Can you remove this limitation?
>
> The code would need to be restructured a bit to support that, but
> definitely feel free to submit a PR to remove that limitation.
>
> > Thanks & Regards,
> > Marian
> > _______________________________________________
> > Dev mailing list -- dev(a)ceph.io
> > To unsubscribe send an email to dev-leave(a)ceph.io
> >
>
>
> --
> Jason
>
--
Jason
1518
days inactive
1518
days old
3 comments
3 participants
participants (3)
-
Jason Dillaman -
Marian Krucina -
marian.krucina＠gmail.com