Hi, Seems backport bot is broken for some reason, see [1] Can somebody take a look and keep bot alive? [1] https://tracker.ceph.com/issues/64511#note-4 Thanks, k
On Fri, May 10, 2024 at 7:56 AM Konstantin Shalygin <k0ste@k0ste.ru> wrote:
Hi,
Seems backport bot is broken for some reason, see [1] Can somebody take a look and keep bot alive?
[1] https://tracker.ceph.com/issues/64511#note-4
Thanks, k _______________________________________________ Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
running the command with no arguments, i see this failure: WARNING:root:Missing issues will be created in Backport tracker of the relevant Redmine project INFO:root:Redmine key was read from '~/.redmine_key'; using it INFO:root:Processing 20 issues with status Pending Backport Traceback (most recent call last): File "/home/cbodley/ceph/build/../src/script/backport-create-issue", line 397, in <module> iterate_over_backports(redmine, issues, dry_run=args.dry_run) File "/home/cbodley/ceph/build/../src/script/backport-create-issue", line 340, in iterate_over_backports update_relations(r, issue, dry_run) File "/home/cbodley/ceph/build/../src/script/backport-create-issue", line 242, in update_relations other = r.issue.create(project_id=issue['project']['id'], File "/home/cbodley/ceph/build/virtualenv/lib64/python3.9/site-packages/redminelib/managers/base.py", line 187, in create response = self.redmine.engine.request(self.resource_class.http_method_create, url, data=request) File "/home/cbodley/ceph/build/virtualenv/lib64/python3.9/site-packages/redminelib/engines/base.py", line 83, in request return self.process_response(self.session.request(method, url, **kwargs)) File "/home/cbodley/ceph/build/virtualenv/lib64/python3.9/site-packages/redminelib/engines/base.py", line 178, in process_response raise exceptions.ValidationError(', '.join(': '.join(e) if isinstance(e, list) else e for e in errors)) redminelib.exceptions.ValidationError: Assignee is invalid the bot must be stuck on the same thing
i added some debug logs to the script and found that it was complaining about the following assignees: Seena Fallah Igor Gomon Pierre Riteau adding the Developer role to each allowed the script to complete successfully. i'm not sure why these users couldn't be assigned to backports, when they were assigned to the original issues. any ideas? were permissions reverted at some point? or are there different permissions for backport issues? i worry that we'll keep seeing this break for other users p.s. i also saw some 'Internal error' failures, and had to rerun the command several times. i've occasionally seen the same from the web ui since redmine was upgraded:
redminelib.exceptions.ServerError: Redmine returned internal error, check Redmine logs for details
On Fri, May 10, 2024 at 8:40 AM Casey Bodley <cbodley@redhat.com> wrote:
On Fri, May 10, 2024 at 7:56 AM Konstantin Shalygin <k0ste@k0ste.ru> wrote:
Hi,
Seems backport bot is broken for some reason, see [1] Can somebody take a look and keep bot alive?
[1] https://tracker.ceph.com/issues/64511#note-4
Thanks, k _______________________________________________ Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
running the command with no arguments, i see this failure:
WARNING:root:Missing issues will be created in Backport tracker of the relevant Redmine project INFO:root:Redmine key was read from '~/.redmine_key'; using it INFO:root:Processing 20 issues with status Pending Backport Traceback (most recent call last): File "/home/cbodley/ceph/build/../src/script/backport-create-issue", line 397, in <module> iterate_over_backports(redmine, issues, dry_run=args.dry_run) File "/home/cbodley/ceph/build/../src/script/backport-create-issue", line 340, in iterate_over_backports update_relations(r, issue, dry_run) File "/home/cbodley/ceph/build/../src/script/backport-create-issue", line 242, in update_relations other = r.issue.create(project_id=issue['project']['id'], File "/home/cbodley/ceph/build/virtualenv/lib64/python3.9/site-packages/redminelib/managers/base.py", line 187, in create response = self.redmine.engine.request(self.resource_class.http_method_create, url, data=request) File "/home/cbodley/ceph/build/virtualenv/lib64/python3.9/site-packages/redminelib/engines/base.py", line 83, in request return self.process_response(self.session.request(method, url, **kwargs)) File "/home/cbodley/ceph/build/virtualenv/lib64/python3.9/site-packages/redminelib/engines/base.py", line 178, in process_response raise exceptions.ValidationError(', '.join(': '.join(e) if isinstance(e, list) else e for e in errors)) redminelib.exceptions.ValidationError: Assignee is invalid
the bot must be stuck on the same thing
Nice, now we can backport this PR's
On 10 May 2024, at 17:21, Casey Bodley <cbodley@redhat.com> wrote:
p.s. i also saw some 'Internal error' failures, and had to rerun the command several times. i've occasionally seen the same from the web ui since redmine was upgraded:
I'm also faced some 500s after upgrading. Maybe new Redmine needs more resources Thanks, k
Hey Konstantin/Casey if you are facing those errors when running scripts against the tracker we have some rate limit settings on the tracker http service to protect against DDos attackers so I will need to see the script you are running and maybe you will need to reduce the number of http requests your script is doing over time. regarding access permissions to users it wasn't changed at all during the upgrade from what I know. Thanks On Fri, May 10, 2024 at 7:49 PM Konstantin Shalygin <k0ste@k0ste.ru> wrote:
Nice, now we can backport this PR's
On 10 May 2024, at 17:21, Casey Bodley <cbodley@redhat.com> wrote:
p.s. i also saw some 'Internal error' failures, and had to rerun the command several times. i've occasionally seen the same from the web ui since redmine was upgraded:
I'm also faced some 500s after upgrading. Maybe new Redmine needs more resources
Thanks, k
ok, thanks Adam the script is https://github.com/ceph/ceph/blob/main/src/script/backport-create-issue which runs every 5 minutes as a github action. rate limiting shouldn't be an issue as long as it can make some progress each run On Sun, May 12, 2024 at 7:29 AM Adam Kraitman <akraitma@redhat.com> wrote:
Hey Konstantin/Casey if you are facing those errors when running scripts against the tracker we have some rate limit settings on the tracker http service to protect against DDos attackers so I will need to see the script you are running and maybe you will need to reduce the number of http requests your script is doing over time. regarding access permissions to users it wasn't changed at all during the upgrade from what I know.
Thanks
On Fri, May 10, 2024 at 7:49 PM Konstantin Shalygin <k0ste@k0ste.ru> wrote:
Nice, now we can backport this PR's
On 10 May 2024, at 17:21, Casey Bodley <cbodley@redhat.com> wrote:
p.s. i also saw some 'Internal error' failures, and had to rerun the command several times. i've occasionally seen the same from the web ui since redmine was upgraded:
I'm also faced some 500s after upgrading. Maybe new Redmine needs more resources
Thanks, k
participants (3)
-
Adam Kraitman
-
Casey Bodley
-
Konstantin Shalygin