8 Oct
2019
8 Oct
'19
6:01 p.m.
hi folks,
tl;dr: it's a notice/RFC that `do_cmake.sh` won't pass do Debug build
anymore after https://github.com/ceph/ceph/pull/30250 gets merged.
long story: i am refactoring do_cmake.sh so we can build Release build
by passing '-DCMAKE_BUILD_TYPE=Release' to it. so i can leverage the
existing scripts for running performance test. the reason why i'd
prefer change the existing behavior is that i want to keep do_cmake.sh
simpler and straightforward, if we want to keep
"-DCMAKE_BUILD_TYPE=Debug" as the default behavior, we would need to
either introduce another command line argument or parse and for this
parameter passed in.
instead, run-make-check.sh will pass -DCMAKE_BUILD_TYPE=Debug to
cmake, so if you are using this script to build your tree or run "make
check", you are not impacted.
please let me know if you have any concerns. otherwise, i will update
this script by the end of the week (Oct 12).
cheers,
--
Regards
Kefu Chai
8 Oct
8 Oct
6:56 p.m.
Would https://github.com/ceph/ceph/pull/30799 be a good idea then or
does having a default of 'RelWithDebInfo' still make sense?
On Wed, Oct 9, 2019 at 11:12 AM kefu chai <tchaikov(a)gmail.com> wrote:
hi folks,
tl;dr: it's a notice/RFC that `do_cmake.sh` won't pass do Debug build
anymore after https://github.com/ceph/ceph/pull/30250 gets merged.
long story: i am refactoring do_cmake.sh so we can build Release build
by passing '-DCMAKE_BUILD_TYPE=Release' to it. so i can leverage the
existing scripts for running performance test. the reason why i'd
prefer change the existing behavior is that i want to keep do_cmake.sh
simpler and straightforward, if we want to keep
"-DCMAKE_BUILD_TYPE=Debug" as the default behavior, we would need to
either introduce another command line argument or parse and for this
parameter passed in.
instead, run-make-check.sh will pass -DCMAKE_BUILD_TYPE=Debug to
cmake, so if you are using this script to build your tree or run "make
check", you are not impacted.
please let me know if you have any concerns. otherwise, i will update
this script by the end of the week (Oct 12).
cheers,
--
Regards
Kefu Chai
_______________________________________________
Dev mailing list -- dev(a)ceph.io
To unsubscribe send an email to dev-leave(a)ceph.io
--
Cheers,
Brad
7:56 p.m.
On Wed, 9 Oct 2019, kefu chai wrote:
hi folks,
tl;dr: it's a notice/RFC that `do_cmake.sh` won't pass do Debug build
anymore after https://github.com/ceph/ceph/pull/30250 gets merged.
I like(d) that the default do_make.sh incantation does a debug build,
which has lockdep enabled, which means that most development and basic
vstart testing happens with lockdep enabled.
If it's not too much complexity, IMO it would be nice if do_cmake sitll
defaulted to a debug build (but was maybe clever enough to still let you
do a release build for the perf tests)...?
sage
>
> long story: i am refactoring do_cmake.sh so we can build Release build
> by passing '-DCMAKE_BUILD_TYPE=Release' to it. so i can leverage the
> existing scripts for running performance test. the reason why i'd
> prefer change the existing behavior is that i want to keep do_cmake.sh
> simpler and straightforward, if we want to keep
> "-DCMAKE_BUILD_TYPE=Debug" as the default behavior, we would need to
> either introduce another command line argument or parse and for this
> parameter passed in.
>
> instead, run-make-check.sh will pass -DCMAKE_BUILD_TYPE=Debug to
> cmake, so if you are using this script to build your tree or run "make
> check", you are not impacted.
>
> please let me know if you have any concerns. otherwise, i will update
> this script by the end of the week (Oct 12).
>
> cheers,
>
> --
> Regards
> Kefu Chai
> _______________________________________________
> Dev mailing list -- dev(a)ceph.io
> To unsubscribe send an email to dev-leave(a)ceph.io
>
>
9:11 p.m.
On Wed, Oct 9, 2019 at 10:56 AM Sage Weil <sweil(a)redhat.com> wrote:
On Wed, 9 Oct 2019, kefu chai wrote:
thanks the inputs, Sage. will try to get Brad's change merged first,
so do_cmake.sh will default to Debug build even with my change.
On Wed, Oct 9, 2019 at 9:56 AM Brad Hubbard <bhubbard(a)redhat.com> wrote:
hi folks,
tl;dr: it's a notice/RFC that `do_cmake.sh` won't pass do Debug build
anymore after https://github.com/ceph/ceph/pull/30250 gets merged.
I like(d) that the default do_make.sh incantation does a debug build,
which has lockdep enabled, which means that most development and basic
vstart testing happens with lockdep enabled.
If it's not too much complexity, IMO it would be nice if do_cmake sitll
defaulted to a debug build (but was maybe clever enough to still let you
do a release build for the perf tests)...?
Would https://github.com/ceph/ceph/pull/30799 be a good idea then or
does having a default of 'RelWithDebInfo' still make sense?
thank you, Brad! this change looks great!
sage
>
> long story: i am refactoring do_cmake.sh so we can build Release build
> by passing '-DCMAKE_BUILD_TYPE=Release' to it. so i can leverage the
> existing scripts for running performance test. the reason why i'd
> prefer change the existing behavior is that i want to keep do_cmake.sh
> simpler and straightforward, if we want to keep
> "-DCMAKE_BUILD_TYPE=Debug" as the default behavior, we would need to
> either introduce another command line argument or parse and for this
> parameter passed in.
>
> instead, run-make-check.sh will pass -DCMAKE_BUILD_TYPE=Debug to
> cmake, so if you are using this script to build your tree or run "make
> check", you are not impacted.
>
> please let me know if you have any concerns. otherwise, i will update
> this script by the end of the week (Oct 12).
>
> cheers,
>
> --
> Regards
> Kefu Chai
> _______________________________________________
> Dev mailing list -- dev(a)ceph.io
> To unsubscribe send an email to dev-leave(a)ceph.io
>
>
--
Regards
Kefu Chai
9:35 p.m.
On Wed, Oct 9, 2019 at 2:11 PM kefu chai <tchaikov(a)gmail.com> wrote:
--
Cheers,
Brad
On Wed, Oct 9, 2019 at 10:56 AM Sage Weil <sweil(a)redhat.com> wrote:
Thank you, as always, for your input.
If it's not too much complexity, IMO it would
be nice if do_cmake sitll
defaulted to a debug build (but was maybe clever enough to still let you
do a release build for the perf tests)...?
thanks the inputs, Sage. will try to get Brad's change merged first,
so do_cmake.sh will default to Debug build even with my change.
On Wed, Oct 9, 2019 at 9:56 AM Brad Hubbard <bhubbard(a)redhat.com> wrote:
Would https://github.com/ceph/ceph/pull/30799 be a good idea then or
does having a default of 'RelWithDebInfo' still make sense?
thank you, Brad! this change looks great!
sage
>
> long story: i am refactoring do_cmake.sh so we can build Release build
> by passing '-DCMAKE_BUILD_TYPE=Release' to it. so i can leverage the
> existing scripts for running performance test. the reason why i'd
> prefer change the existing behavior is that i want to keep do_cmake.sh
> simpler and straightforward, if we want to keep
> "-DCMAKE_BUILD_TYPE=Debug" as the default behavior, we would need to
> either introduce another command line argument or parse and for this
> parameter passed in.
>
> instead, run-make-check.sh will pass -DCMAKE_BUILD_TYPE=Debug to
> cmake, so if you are using this script to build your tree or run "make
> check", you are not impacted.
>
> please let me know if you have any concerns. otherwise, i will update
> this script by the end of the week (Oct 12).
>
> cheers,
>
> --
> Regards
> Kefu Chai
> _______________________________________________
> Dev mailing list -- dev(a)ceph.io
> To unsubscribe send an email to dev-leave(a)ceph.io
>
>
--
Regards
Kefu Chai
1673
days inactive
1673
days old
4 comments
3 participants
participants (3)
-
Brad Hubbard -
kefu chai -
Sage Weil