On 20-4-2020 18:07, kefu chai wrote:

Le lun. 20 avr. 2020 à 19:53, Willem Jan Withagen <wjw@digiware.nl> a écrit :

On 20-4-2020 13:26, kefu chai wrote:
> On Sun, Apr 19, 2020 at 7:00 PM Willem Jan Withagen <wjw@digiware.nl> wrote:
>> Hi Kefu,
>>
>> This looks like a possible not correctly initialised difference?
>> Am I correct in assuming that?
>>
>> Or suggestions to debug this?
> i think you already found the PR addressing this issue and filed
> https://tracker.ceph.com/issues/45130?
>
> anything i am missing?

That PR was about the check-generated script not being able to set
the return result in case of failure. Due to Bash creating a subshell
for the while-loop, and thus putting counting variables in a different
scope. Which you fixed in this PR.

Once Fixed, I'm getting errors reported when running the script for testing
RGWObjManifest
and later on
bluestore_bdev_label_t

So for these 2 cases `dump_json` and `encode decode dump_json` give
different results.
I very much suspect that it could be that there is a difference bewween
initializing an object
and decoding an object in the way some fields are handled

But I haven't found that (yet).

I see. Willem, can you see the same issue on master or octopus?

Octopus does not seem to have this issue.

When I compare the difference between Nautilus and Octopus output is in quite a few fields.
And it seems that there is a lot more initialised in the original block.
So probably that is the place to look, and try to find the commit that fixes that?

--WjW

--WjW

>
>> Thanx,
>> --WjW
>>
>> Start 94: check-generated.sh
>> 1/2 Test #94: check-generated.sh ...............***Failed 58.52 sec
>> Enivronment Variables Already Set
>> checking ceph-dencoder generated test instances...
>> numgen type
>> ................................
>> 2 RGWOLHInfo
>> 2 RGWObjManifest
>> /tmp/typ-biXq5mHqd /tmp/typ-m55peHsmj differ: char 8124, line 278
>> **** RGWObjManifest test 1 dump_json check failed ****
>> ceph-dencoder type RGWObjManifest select_test 1 dump_json >
>> /tmp/typ-biXq5mHqd
>> ceph-dencoder type RGWObjManifest select_test 1 encode decode dump_json
>> > /tmp/typ-m55peHsmj
>> 278c278
>> < "name": "",
>> ---
>>> "name": "0",
>> 280c280
>> < "ns": ""
>> ---
>>> "ns": "shadow"
>> 294c294
>> < "ofs": 0,
>> ---
>>> "ofs": 5242880,
>> 314c314
>> < "name": "",
>> ---
>>> "name": "0",
>> 316c316
>> < "ns": ""
>> ---
>>> "ns": "shadow"
>> Start 112: unittest_journal
>> 2/2 Test #112: unittest_journal ................. Passed 5.47 sec
>>
>> 50% tests passed, 1 tests failed out of 2
>>
>> Total Test time (real) = 64.04 sec
>>
>> The following tests FAILED:
>> 94 - check-generated.sh (Failed)
>> Errors while running CTest
>> Build step 'Execute shell' marked build as failure
>
>

--

Regards
Kefu Chai
_______________________________________________
Dev mailing list -- dev@ceph.io
To unsubscribe send an email to dev-leave@ceph.io