One point - this PR was presented months ago and the design was discussed in the team, and with cooperation of several team members - changing it after it was implemented seems like a non-friendly process :-(.

Secondly the design supports user hints which may suggest that the data should not be compressed. It was not implemented because of time shortage (this feature is part of a collaboration with the academy and was performed by an experienced grad student, but under some time limits). Implementing this hint can solve the problem of compressed data sent by RGW.

Regards,

Josh

On Thu, Feb 4, 2021 at 2:57 AM majianpeng <jianpeng.ma@intel.com> wrote:

we may need a method like CEPH_OSD_OP_FLAG_FADVISE_* to bypass msg2 / bluestore compress. For objstore, client maybe already compress the data(attribute: user.rgw.content_encoding). So need recompress on msg layer or bluestore layer.
I very much agree with Sage’s second idea. It like https://lwn.net/Articles/837816/ (Encode I/O). This can largely reduce network and CPU.
_______________________________________________
Dev mailing list -- dev@ceph.io
To unsubscribe send an email to dev-leave@ceph.io