- Dev - lists.ceph.io

mgr modules' subinterpreter use and their pyo3 incompatibility

by Matthew Vernon

Hi, I'm referring to https://tracker.ceph.com/issues/64213 and the older https://tracker.ceph.com/issues/63529 (which relates to the dashboard mgr module specifically). But basically, the use of pyo3 isn't safe in subinterpreters[0], and it introduced a check to error out on such use. This is already causing problems in Debian bookworm (I think my chance that a version of pyo3 with the check got released there first - it looks like both Ubuntu 23.04 and now centos9 are likely also affected?), although the MR that takes the problematic code out of the dashboard may help somewhat (and I've opened an MR to backport it to reef - https://github.com/ceph/ceph/pull/55689 ). I may have missed discussion on it, but is there a plan for addressing this set of issues, please? It doesn't look like multiple subinterpreter support in pyo3 is going to happen any time soon... Regards, Matthew [0] https://github.com/PyO3/pyo3/issues/576

2 months

3
3
0 0

02/22/2024 perf meeting is canceled

by Mark Nelson

Hi Folks, I won't be able to make it today. Let's reconvene next week! Thanks, Mark -- Best Regards, Mark Nelson Head of R&D (USA) Clyso GmbH p: +49 89 21552391 12 a: Loristraße 8 | 80335 München | Germany w: https://clyso.com | e: mark.nelson(a)clyso.com We are hiring: https://www.clyso.com/jobs/

2 months, 1 week

1
0
0 0

Ceph Leadership Team Meeting: 2024-2-21 Minutes

by Casey Bodley

Estimate on release timeline for 17.2.8? - after pacific 16.2.15 and reef 18.2.2 hotfix (https://tracker.ceph.com/issues/64339, https://tracker.ceph.com/issues/64406) Estimate on release timeline for 19.2.0? - target April, depending on testing and RCs - Testing plan for Squid beyond dev freeze (regression and upgrade tests, performance tests, RCs) Can we fix old.ceph.com? - continued discussion about the need to revive the pg calc tool T release name? - please add and vote for suggestions in https://pad.ceph.com/p/t - need name before we can open "t kickoff" pr

2 months, 1 week

1
0
0 0

Tripsitter: A Psychedelics, Ketamine, & Cannabis Encyclopedia

by Leon Vergara

In today's ever-evolving world of travel and exploration, there is a growing fascination with alternative forms of experiencing new places and cultures. One such trend that has gained significant traction is the use of psychedelics, ketamine, and cannabis to enhance the travel experience. While these substances may have previously been viewed with skepticism and controversy, they are now being explored and appreciated as tools for personal growth, spiritual exploration, and even medicinal purposes. Tripsitter: A Psychedelics, Ketamine, & Cannabis Encyclopedia is here to guide curious travelers on this journey. Tripsitter is an all-encompassing resource that delves deep into the world of psychedelics, ketamine, and cannabis. It serves as a comprehensive encyclopedia that covers everything from the history and cultural perspectives surrounding these substances to practical advice on dosage, safety precautions, and mindful consumption. With its vast array of information, Tripsitter is the go-to guide for those seeking responsible and informed guidance on incorporating these substances into their travel experiences. Exploring the history and cultural significance of psychedelics, Tripsitter sheds light on their origins and reveals the rich tapestry woven throughout time. These substances have been part of various ancient civilizations' rituals, spiritual practices, and tribal ceremonies. By understanding the historical context and cultural importance, travelers can develop a deeper appreciation for how psychedelics have shaped and continue to shape human culture. Tripsitter recognizes that responsible use and education are of utmost importance when it comes to any substance use. Whether one is a seasoned traveler or new to psychedelics, Tripsitter offers guidance on the responsible consumption of these substances. From emphasizing the importance of proper research and testing to providing guidelines on dosing and preparation, Tripsitter equips travelers with the necessary knowledge to have safe and meaningful experiences. In addition to its focus on psychedelics, Tripsitter also acknowledges the growing interest in ketamine and cannabis as tools for travel enhancement. The encyclopedia provides in-depth information on the scientifically-backed benefits of ketamine for mental health and its potential role in aiding conditions such as depression and PTSD. Similarly, it delves into the varied uses of cannabis, exploring its medicinal applications and highlighting the significance of responsible use for individuals looking to capitalize on its potential benefits during their travels. One notable strength of Tripsitter lies in its approach to harm reduction and risk mitigation. While acknowledging that the use of these substances can have positive effects for many individuals, Tripsitter also notes the importance of setting intentions, engaging in proper integration practices, and providing tips for avoiding potential pitfalls. This approach ensures that readers are aware of both the rewarding aspects and the potential risks associated with engaging in the use of psychedelics, ketamine, and cannabis during their travels. In conclusion, Tripsitter: A Psychedelics, Ketamine, & Cannabis Encyclopedia promises to be an invaluable resource for travelers seeking to enhance their journeys through the exploration of mind-altering substances. By drawing upon historical precedents, providing practical advice, and highlighting the potential benefits, Tripsitter offers a thoughtful and holistic approach to using psychedelics, ketamine, and cannabis responsibly during travel. However, readers should always prioritize self-care, safety, and informed decision-making when navigating this realm. There is great potential to elevate the travel experience, expand one's consciousness, and find deeper connections to the world with the assistance of Tripsitter as a knowledgeable and well-rounded travel companion. Company Name: Tripsitter Magazine Company website: https://tripsitter.com/ Address: 4498 Main St Ste 4 #5040 Amherst, NY 14226, United States Phone: +1-716-839-4444 Email: high(a)tripsitter.com Tags: #psychedelics, #magicmushrooms, #ketamine, #mdma, #cannabis

2 months, 1 week

1
0
0 0

Re: Insane number of "osd_snap purged_snap" keys in monstore db due to rbd-mirror

by Eugen Block

Hi, this thread has been inactive for quite some time, I thought I'd try to revive it. Is there any chance for a better mon store trimming regarding purged_snap and purge_epoch keys? Thanks! Eugen

2 months, 1 week

2
2
0 0

User + Dev Meetup February 22 - CephFS Snapshots story!

by Neha Ojha

Hi everyone, You are invited to join us at the User + Dev meeting this week Thursday, February 22 at 10:00 AM Eastern Time! Focus Topic: CephFS Snapshots Evaluation Presented by: Enrico Bocchi and Abhishek Lekshmanan, Ceph operators from CERN From the presenters: Ceph at CERN provides block, object, and file storage backing the IT infrastructure of the Organization. CephFS, in particular, is largely used through the integration with OpenStack Manila by container-based workloads (Kubernetes, OpenShift), HPC MPI clusters, and as a general-purpose networked file system for enterprise groupware and open infrastructure technologies (code/software repositories, monitoring, analytics, etc.). Our presentation focuses on CephFS snapshots and their implications on performance and stability. Snapshots would be a valuable addition to our existing CephFS service, as they allow for storage rollback and disaster recovery through mirroring. According to our observations, however, they introduce a non-negligible performance penalty and may jeopardize the stability of the file system. In particular, we would like to discuss: 1. Experiences with CephFS snapshots from other operators in the Ceph community. 2. Tools and strategies one can deploy to pre-empty or mitigate issues. 3. How to effectively contribute with upstream developers and interested community users to address the identified limitations. Feel free to add questions or additional topics under the "Open Discussion" section on the agenda: https://pad.ceph.com/p/ceph-user-dev-monthly-minutes If you have an idea for a focus topic you'd like to present at a future meeting, you are welcome to submit it to this Google Form: https://docs.google.com/forms/d/e/1FAIpQLSdboBhxVoBZoaHm8xSmeBoemuXoV_rmh4v… Any Ceph user or developer is eligible to submit! Thanks, Neha

2 months, 1 week

1
0
0 0

New Defects reported by Coverity Scan for ceph

by scan-admin＠coverity.com

Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. 120 new defect(s) introduced to ceph found with Coverity Scan. 13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 120 defect(s) ** CID 1592287: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/crush/CrushWrapper.cc: 2476 in CrushWrapper::add_indep_multi_osd_per_failure_domain_rule(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::basic_ostream<char, std::char_traits<char>>*)() ________________________________________________________________________________________________________ *** CID 1592287: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/crush/CrushWrapper.cc: 2476 in CrushWrapper::add_indep_multi_osd_per_failure_domain_rule(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::basic_ostream<char, std::char_traits<char>>*)() 2470 int osds_per_failure_domain, 2471 string device_class, 2472 ostream *err) 2473 { 2474 return add_multi_osd_per_failure_domain_rule_at( 2475 name, root_name, >>> CID 1592287: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "failure_domain_name" is passed-by-value as parameter to "add_multi_osd_per_failure_domain_rule_at" when it could be moved instead. 2476 failure_domain_name, 2477 num_failure_domains, 2478 osds_per_failure_domain, 2479 device_class, 2480 CRUSH_RULE_TYPE_MSR_INDEP, 2481 -1, ** CID 1592286: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/crush/CrushWrapper.h: 1269 in CrushWrapper::add_simple_rule_at(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, int, std::basic_ostream<char, std::char_traits<char>>*)() ________________________________________________________________________________________________________ *** CID 1592286: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/crush/CrushWrapper.h: 1269 in CrushWrapper::add_simple_rule_at(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, int, std::basic_ostream<char, std::char_traits<char>>*)() 1263 std::string name, std::string root_name, 1264 std::string failure_domain_type, 1265 std::string device_class, std::string mode, 1266 int rule_type, int rno, std::ostream *err = 0) { 1267 return add_simple_rule_at( 1268 name, root_name, failure_domain_type, -1, >>> CID 1592286: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "device_class" is passed-by-value as parameter to "add_simple_rule_at" when it could be moved instead. 1269 device_class, mode, rule_type, rno, err); 1270 } 1271 1272 int add_multi_osd_per_failure_domain_rule_at( 1273 std::string name, std::string root_name, std::string failure_domain_type, 1274 int osds_per_failure_domain, ** CID 1592285: Uninitialized variables (UNINIT) /src/static/src/github/ceph/src/qatlib/quickassist/lookaside/access_layer/src/sample_code/functional/sym/hkdf_sample/cpa_hkdf_sample.c: 601 in hkdfSampleExtractExpandPerform() ________________________________________________________________________________________________________ *** CID 1592285: Uninitialized variables (UNINIT) /src/static/src/github/ceph/src/qatlib/quickassist/lookaside/access_layer/src/sample_code/functional/sym/hkdf_sample/cpa_hkdf_sample.c: 601 in hkdfSampleExtractExpandPerform() 595 * sure that the structures won't be needed any more. Free the 596 * memory! 597 */ 598 PHYS_CONTIG_FREE(pHkdfData); 599 PHYS_CONTIG_FREE(pOpData); 600 >>> CID 1592285: Uninitialized variables (UNINIT) >>> Using uninitialized value "complete.semaphore" when calling "sem_destroy". 601 COMPLETION_DESTROY(&complete); 602 603 return status; 604 } 605 606 CpaStatus hkdfSample(void) ** CID 1592284: Incorrect expression (USELESS_CALL) ________________________________________________________________________________________________________ *** CID 1592284: Incorrect expression (USELESS_CALL) /src/static/src/github/ceph/src/qatzip/test/main.c: 3321 in qzCompressFailedAtBufferOverflow() 3315 done: 3316 free(src); 3317 free(comp); 3318 free(low_comp); 3319 free(low_decomp); 3320 (void)qzTeardownSession(&sess); >>> CID 1592284: Incorrect expression (USELESS_CALL) >>> Calling "qzClose(&sess)" is only useful for its return value, which is ignored. 3321 qzClose(&sess); 3322 return rc; 3323 } 3324 3325 int doQzCompressCrcCheck(size_t orig_sz) 3326 { ** CID 1592283: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/osd/ECBackend.cc: 763 in ECBackend::recover_object(const hobject_t &, eversion_t, std::shared_ptr<ObjectContext>, std::shared_ptr<ObjectContext>, PGBackend::RecoveryHandle *)() ________________________________________________________________________________________________________ *** CID 1592283: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/osd/ECBackend.cc: 763 in ECBackend::recover_object(const hobject_t &, eversion_t, std::shared_ptr<ObjectContext>, std::shared_ptr<ObjectContext>, PGBackend::RecoveryHandle *)() 757 const hobject_t &hoid, 758 eversion_t v, 759 ObjectContextRef head, 760 ObjectContextRef obc, 761 RecoveryHandle *_h) 762 { >>> CID 1592283: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "head" is passed-by-value as parameter to "recover_object" when it could be moved instead. 763 return recovery_backend.recover_object(hoid, v, head, obc, _h); 764 } 765 766 int ECBackend::RecoveryBackend::recover_object( 767 const hobject_t &hoid, 768 eversion_t v, ** CID 1592282: Incorrect expression (USELESS_CALL) ________________________________________________________________________________________________________ *** CID 1592282: Incorrect expression (USELESS_CALL) /src/static/src/github/ceph/src/qatzip/test/main.c: 3094 in qzDecompressHWFailedAtUnknownGzipBlock() 3088 3089 done: 3090 qzFree(orig_src); 3091 qzFree(comp_src); 3092 qzFree(decomp_src); 3093 (void)qzTeardownSession(&sess); >>> CID 1592282: Incorrect expression (USELESS_CALL) >>> Calling "qzClose(&sess)" is only useful for its return value, which is ignored. 3094 qzClose(&sess); 3095 return rc; 3096 } 3097 3098 int qzDecompressForceSW(void) 3099 { ** CID 1592281: Error handling issues (CHECKED_RETURN) /src/static/src/github/ceph/src/qatlib/quickassist/lookaside/access_layer/src/sample_code/performance/compression/qat_compression_utils.c: 1921 in performDcChainOffloadCalculationBusyLoop() ________________________________________________________________________________________________________ *** CID 1592281: Error handling issues (CHECKED_RETURN) /src/static/src/github/ceph/src/qatlib/quickassist/lookaside/access_layer/src/sample_code/performance/compression/qat_compression_utils.c: 1921 in performDcChainOffloadCalculationBusyLoop() 1915 upperBound = pPerfData->busyLoopValue; 1916 1917 while (CPA_STATUS_SUCCESS == status && lowerBound <= upperBound) 1918 { 1919 pPerfData->busyLoopValue = (upperBound + lowerBound) / 2; 1920 >>> CID 1592281: Error handling issues (CHECKED_RETURN) >>> Calling "qatDcChainCompressData" without checking return value (as is done elsewhere 5 out of 6 times). 1921 qatDcChainCompressData(setup, 1922 pSessionHandle, 1923 dcSessDir, 1924 arrayOfSrcBufferLists, 1925 arrayOfDestBufferLists, 1926 arrayOfCmpBufferLists, ** CID 1592280: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/rgw/driver/rados/rgw_rados.cc: 3114 in RGWRados::Object::Write::_do_write_meta(unsigned long, unsigned long, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, ceph::buffer::v15_2_0::list, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::allocator<std::pair<const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, ceph::buffer::v15_2_0::list>>> &, bool, bool, void *, const req_context &, opentelemetry::v1::trace::SpanContext &, bool)() ________________________________________________________________________________________________________ *** CID 1592280: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/rgw/driver/rados/rgw_rados.cc: 3114 in RGWRados::Object::Write::_do_write_meta(unsigned long, unsigned long, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, ceph::buffer::v15_2_0::list, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::allocator<std::pair<const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, ceph::buffer::v15_2_0::list>>> &, bool, bool, void *, const req_context &, opentelemetry::v1::trace::SpanContext &, bool)() 3108 3109 if (target->get_bucket_info().obj_lock_enabled() && target->get_bucket_info().obj_lock.has_rule() && meta.flags == PUT_OBJ_CREATE) { 3110 auto iter = attrs.find(RGW_ATTR_OBJECT_RETENTION); 3111 if (iter == attrs.end()) { 3112 real_time lock_until_date = target->get_bucket_info().obj_lock.get_lock_until_date(meta.set_mtime); 3113 string mode = target->get_bucket_info().obj_lock.get_mode(); >>> CID 1592280: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "mode" is passed-by-value as parameter to "RGWObjectRetention::RGWObjectRetention(std::string, ceph::real_time)" when it could be moved instead. 3114 RGWObjectRetention obj_retention(mode, lock_until_date); 3115 bufferlist bl; 3116 obj_retention.encode(bl); 3117 op.setxattr(RGW_ATTR_OBJECT_RETENTION, bl); 3118 } 3119 } ** CID 1592279: Incorrect expression (USELESS_CALL) ________________________________________________________________________________________________________ *** CID 1592279: Incorrect expression (USELESS_CALL) /src/static/src/github/ceph/src/qatzip/test/main.c: 2951 in qzDecompressFailedAtUnknownGzipHeader() 2945 2946 done: 2947 qzFree(orig_src); 2948 qzFree(comp_src); 2949 qzFree(decomp_src); 2950 (void)qzTeardownSession(&sess); >>> CID 1592279: Incorrect expression (USELESS_CALL) >>> Calling "qzClose(&sess)" is only useful for its return value, which is ignored. 2951 qzClose(&sess); 2952 return rc; 2953 } 2954 2955 int qzDecompressSWFailedAtUnknownGzipBlock(void) 2956 { ** CID 1592278: Error handling issues (CHECKED_RETURN) /src/static/src/github/ceph/src/test/objectstore/allocator_replay_test.cc: 730 in main::[lambda(Allocator *, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &) (instance 4)]::operator ()(Allocator *, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &) const() ________________________________________________________________________________________________________ *** CID 1592278: Error handling issues (CHECKED_RETURN) /src/static/src/github/ceph/src/test/objectstore/allocator_replay_test.cc: 730 in main::[lambda(Allocator *, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &) (instance 4)]::operator ()(Allocator *, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &) const() 724 << std::endl; 725 726 /* Do not release. */ 727 //alloc->release(extents); 728 extents.clear(); 729 } >>> CID 1592278: Error handling issues (CHECKED_RETURN) >>> Calling "fseek" without checking return value (as is done elsewhere 10 out of 11 times). 730 fseek(f_alloc_list, 0, SEEK_SET); 731 } 732 fclose(f_alloc_list); 733 std::cout << "Fragmentation:" << a->get_fragmentation() 734 << std::endl; 735 std::cout << "Fragmentation score:" << a->get_fragmentation_score() ** CID 1592277: Error handling issues (CHECKED_RETURN) /src/static/src/github/ceph/src/qatlib/quickassist/lookaside/access_layer/src/qat_direct/vfio/adf_vfio_user_proxy.c: 110 in adf_io_userProcessStop() ________________________________________________________________________________________________________ *** CID 1592277: Error handling issues (CHECKED_RETURN) /src/static/src/github/ceph/src/qatlib/quickassist/lookaside/access_layer/src/qat_direct/vfio/adf_vfio_user_proxy.c: 110 in adf_io_userProcessStop() 104 struct qatmgr_msg_req req = {0}; 105 struct qatmgr_msg_rsp rsp = {0}; 106 107 assert(sizeof(req.name) == sizeof(currentProcess)); 108 ICP_STRLCPY(req.name, currentProcess, sizeof(req.name)); 109 >>> CID 1592277: Error handling issues (CHECKED_RETURN) >>> Calling "qatmgr_query" without checking return value (as is done elsewhere 9 out of 10 times). 110 qatmgr_query(&req, &rsp, QATMGR_MSGTYPE_SECTION_PUT); 111 112 memset(currentProcess, 0, QATMGR_MAX_STRLEN); 113 114 qatmgr_close(); 115 ** CID 1592276: Incorrect expression (USELESS_CALL) ________________________________________________________________________________________________________ *** CID 1592276: Incorrect expression (USELESS_CALL) /src/static/src/github/ceph/src/qatzip/test/main.c: 3449 in qzCompressSWL9DecompressHW() 3443 3444 done: 3445 qzFree(orig_src); 3446 qzFree(comp_src); 3447 qzFree(decomp_src); 3448 (void)qzTeardownSession(&sess); >>> CID 1592276: Incorrect expression (USELESS_CALL) >>> Calling "qzClose(&sess)" is only useful for its return value, which is ignored. 3449 qzClose(&sess); 3450 return rc; 3451 } 3452 3453 int qzFuncTests(void) 3454 { ** CID 1592275: Incorrect expression (USELESS_CALL) ________________________________________________________________________________________________________ *** CID 1592275: Incorrect expression (USELESS_CALL) /src/static/src/github/ceph/src/qatzip/test/main.c: 3265 in qzDecompressStandalone() 3259 3260 done: 3261 free(orig_src); 3262 free(comp_src); 3263 free(decomp_src); 3264 (void)qzTeardownSession(&sess); >>> CID 1592275: Incorrect expression (USELESS_CALL) >>> Calling "qzClose(&sess)" is only useful for its return value, which is ignored. 3265 qzClose(&sess); 3266 return rc; 3267 } 3268 3269 int qzCompressFailedAtBufferOverflow(void) 3270 { ** CID 1592274: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/crush/CrushWrapper.cc: 2370 in CrushWrapper::add_simple_rule(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, std::basic_ostream<char, std::char_traits<char>>*)() ________________________________________________________________________________________________________ *** CID 1592274: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/crush/CrushWrapper.cc: 2370 in CrushWrapper::add_simple_rule(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, std::basic_ostream<char, std::char_traits<char>>*)() 2364 int num_failure_domains, 2365 string device_class, 2366 string mode, int rule_type, 2367 ostream *err) 2368 { 2369 return add_simple_rule_at( >>> CID 1592274: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "root_name" is passed-by-value as parameter to "add_simple_rule_at" when it could be moved instead. 2370 name, root_name, failure_domain_name, num_failure_domains, 2371 device_class, 2372 mode, 2373 rule_type, -1, err); 2374 } 2375 ** CID 1592273: Incorrect expression (USELESS_CALL) ________________________________________________________________________________________________________ *** CID 1592273: Incorrect expression (USELESS_CALL) /src/static/src/github/ceph/src/qatzip/test/main.c: 3360 in doQzCompressCrcCheck() 3354 } 3355 3356 done: 3357 free(src); 3358 free(comp); 3359 (void)qzTeardownSession(&sess); >>> CID 1592273: Incorrect expression (USELESS_CALL) >>> Calling "qzClose(&sess)" is only useful for its return value, which is ignored. 3360 qzClose(&sess); 3361 return rc; 3362 } 3363 3364 int qzCompressCrcCheck(void) 3365 { ** CID 1592272: Error handling issues (UNCAUGHT_EXCEPT) /src/static/src/github/ceph/src/crypto/qat/qcccrypto.h: 60 in QccCrypto::~QccCrypto()() ________________________________________________________________________________________________________ *** CID 1592272: Error handling issues (UNCAUGHT_EXCEPT) /src/static/src/github/ceph/src/crypto/qat/qcccrypto.h: 60 in QccCrypto::~QccCrypto()() 54 auto async_get_instance(CompletionToken&& token); 55 56 public: 57 CpaCySymCipherDirection qcc_op_type; 58 59 QccCrypto() {}; >>> CID 1592272: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "boost::container::length_error_t" is thrown but the exception specification "/*implicit*/noexcept" doesn't allow it to be thrown. This will result in a call to terminate(). 60 ~QccCrypto() { destroy(); }; 61 62 bool init(const size_t chunk_size, const size_t max_requests); 63 bool destroy(); 64 bool perform_op_batch(unsigned char* out, const unsigned char* in, size_t size, 65 Cpa8U *iv, ** CID 1592271: Code maintainability issues (UNUSED_VALUE) /src/static/src/github/ceph/src/qatlib/quickassist/lookaside/access_layer/src/sample_code/performance/compression/cpa_sample_code_dc_dp.c: 2100 in setupDcDpTest() ________________________________________________________________________________________________________ *** CID 1592271: Code maintainability issues (UNUSED_VALUE) /src/static/src/github/ceph/src/qatlib/quickassist/lookaside/access_layer/src/sample_code/performance/compression/cpa_sample_code_dc_dp.c: 2100 in setupDcDpTest() 2094 " number of buffers available (%d)\n", 2095 numRequests, 2096 numberOfBuffersPerFile); 2097 2098 return CPA_STATUS_FAIL; 2099 } >>> CID 1592271: Code maintainability issues (UNUSED_VALUE) >>> Assigning value "0U" to "numberOfBuffersPerFile" here, but that stored value is overwritten before it can be used. 2100 numberOfBuffersPerFile = 0; 2101 } 2102 2103 return status; ** CID 1592270: Incorrect expression (USELESS_CALL) ________________________________________________________________________________________________________ *** CID 1592270: Incorrect expression (USELESS_CALL) /src/static/src/github/ceph/src/qatzip/utils/qzip.c: 540 in qatzipClose() 534 return 0; 535 } 536 537 int qatzipClose(QzSession_T *sess) 538 { 539 qzTeardownSession(sess); >>> CID 1592270: Incorrect expression (USELESS_CALL) >>> Calling "qzClose(sess)" is only useful for its return value, which is ignored. 540 qzClose(sess); 541 542 return 0; 543 } 544 545 QzSuffix_T getSuffix(const char *filename) ** CID 1592269: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/rgw/rgw_aio.cc: 94 in _ZN3rgw11_GLOBAL__N_12aio_abstractIN8librados7v14_2_020ObjectWriteOperationEEEN3fu27abi_3106detail8functionINS7_6configILb1ELb0ELm16EEENS7_8propertyILb1ELb0EJFvPNS_3AioERNS_9AioResultEOEEEEEENS3_5IoCtxEOT_RN5boost4asio10io_contextEN5spawn19basic_yield_contextINSN_15executor_binderIPFvvENSN_15any_io_executorEEEEEPN13opentelemetry2v15trace11SpanContextE() ________________________________________________________________________________________________________ *** CID 1592269: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/rgw/rgw_aio.cc: 94 in _ZN3rgw11_GLOBAL__N_12aio_abstractIN8librados7v14_2_020ObjectWriteOperationEEEN3fu27abi_3106detail8functionINS7_6configILb1ELb0ELm16EEENS7_8propertyILb1ELb0EJFvPNS_3AioERNS_9AioResultEOEEEEEENS3_5IoCtxEOT_RN5boost4asio10io_contextEN5spawn19basic_yield_contextINSN_15executor_binderIPFvvENSN_15any_io_executorEEEEEPN13opentelemetry2v15trace11SpanContextE() 88 }; 89 90 template <typename Op> 91 Aio::OpFunc aio_abstract(librados::IoCtx ctx, Op&& op, 92 boost::asio::io_context& context, 93 spawn::yield_context yield, jspan_context* trace_ctx = nullptr) { >>> CID 1592269: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "yield" is copied in call to copy constructor "spawn::basic_yield_context<boost::asio::executor_binder<void (*)(), boost::asio::any_io_executor> >", when it could be moved instead. 94 return [ctx = std::move(ctx), op = std::move(op), &context, yield, trace_ctx] (Aio* aio, AioResult& r) mutable { 95 // arrange for the completion Handler to run on the yield_context's strand 96 // executor so it can safely call back into Aio without locking 97 using namespace boost::asio; 98 async_completion<spawn::yield_context, void()> init(yield); 99 auto ex = get_associated_executor(init.completion_handler); ** CID 1592268: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/crush/CrushWrapper.h: 1268 in CrushWrapper::add_simple_rule_at(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, int, std::basic_ostream<char, std::char_traits<char>>*)() ________________________________________________________________________________________________________ *** CID 1592268: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /src/static/src/github/ceph/src/crush/CrushWrapper.h: 1268 in CrushWrapper::add_simple_rule_at(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, int, int, std::basic_ostream<char, std::char_traits<char>>*)() 1262 int add_simple_rule_at( 1263 std::string name, std::string root_name, 1264 std::string failure_domain_type, 1265 std::string device_class, std::string mode, 1266 int rule_type, int rno, std::ostream *err = 0) { 1267 return add_simple_rule_at( >>> CID 1592268: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "failure_domain_type" is passed-by-value as parameter to "add_simple_rule_at" when it could be moved instead. 1268 name, root_name, failure_domain_type, -1, 1269 device_class, mode, rule_type, rno, err); 1270 } 1271 1272 int add_multi_osd_per_failure_domain_rule_at( 1273 std::string name, std::string root_name, std::string failure_domain_type, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

2 months, 1 week

1
0
0 0

Squid release in dev freeze phase

by Neha Ojha

The Squid branch has now been cut https://github.com/ceph/ceph/tree/squid. For further bug fixes, let's use our usual procedure of merging to main and backporting to squid. Thanks to everyone who helped us keep on track! Cheers, Neha

2 months, 1 week

1
0
0 0

02/15/2024 perf meeting is on!

by Mark Nelson

Hi Folks, Meeting starts in 10 minutes! Only topic on the agenda today is the Ubuntu/Debian build fix and a new blog article from Hydro-B. Please feel free to add a discussion topic if you have one! Thanks, Mark Etherpad: https://pad.ceph.com/p/performance_weekly Meeting URL: https://meet.google.com/uhb-cysu-nvg Mark -- Best Regards, Mark Nelson Head of R&D (USA) Clyso GmbH p: +49 89 21552391 12 a: Loristraße 8 | 80335 München | Germany w: https://clyso.com | e: mark.nelson(a)clyso.com We are hiring: https://www.clyso.com/jobs/

2 months, 2 weeks

1
0
0 0

[Fw: RoCE?]

by Jan Marek

Hello ceph-dev, I've posted to ceph-users attached message, but I've got no advices, please, can you advise me? Sincerely Jan -- Ing. Jan Marek University of South Bohemia Academic Computer Centre Phone: +420389032080 http://www.gnu.org/philosophy/no-word-attachments.cs.html

2 months, 2 weeks

1
0
0 0

2024

2023

2022

2021

2020

2019

Dev