Diskprediction_local mgr module removal - Call for feedback
Hi everyone, On today's Ceph Steering Committee call we discussed the idea of removing the diskprediction_local mgr module, as the current prediction model is obsolete and not maintained. We would like to gather feedback from the community about the usage of this module, and find out if anyone is interested in maintaining it. Thanks, Yaarit
Hi. From our point of view, it's important to keep disk failure prediction tool as part of Ceph, ideally as an MGR module. In environments with hundreds or thousands of disks, it's crucial to know whether, for example, a significant number of them are likely to fail within a month - which, in the best-case scenario, would mean performance degradation, and in the worst-case, data loss. Some have already responded to the deprecation of diskprediction by starting to develop their own solutions. For instance, just yesterday, Daniel Persson published a solution [1] on his website that addresses the same problem. Would it be possible to join forces and try to revive that module? [1] https://www.youtube.com/watch?v=Gr_GtC9dcMQ Thanks, Michal On 4/8/25 01:18, Yaarit Hatuka wrote:
Hi everyone,
On today's Ceph Steering Committee call we discussed the idea of removing the diskprediction_local mgr module, as the current prediction model is obsolete and not maintained.
We would like to gather feedback from the community about the usage of this module, and find out if anyone is interested in maintaining it.
Thanks, Yaarit _______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
+1 I wasn't aware that this module is obsolete and was trying to start it a few weeks ago. We develop a home-made solution some time ago to monitor smart data from both HDD (uncorrected errors, grown defect list) and SSD (WLC/TBW). But keeping it up to date with non-unified disk models is a nightmare. Alert : "OSD.12 is going to fail. Replace it soon" before seeing SLOW_OPS would be a game changer! Thanks! On Tue, 8 Apr 2025 at 10:00, Michal Strnad <michal.strnad@cesnet.cz> wrote:
Hi.
From our point of view, it's important to keep disk failure prediction tool as part of Ceph, ideally as an MGR module. In environments with hundreds or thousands of disks, it's crucial to know whether, for example, a significant number of them are likely to fail within a month - which, in the best-case scenario, would mean performance degradation, and in the worst-case, data loss.
Some have already responded to the deprecation of diskprediction by starting to develop their own solutions. For instance, just yesterday, Daniel Persson published a solution [1] on his website that addresses the same problem.
Would it be possible to join forces and try to revive that module?
[1] https://www.youtube.com/watch?v=Gr_GtC9dcMQ
Thanks, Michal
Hi everyone,
On today's Ceph Steering Committee call we discussed the idea of removing the diskprediction_local mgr module, as the current prediction model is obsolete and not maintained.
We would like to gather feedback from the community about the usage of
On 4/8/25 01:18, Yaarit Hatuka wrote: this
module, and find out if anyone is interested in maintaining it.
Thanks, Yaarit _______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
_______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
-- Łukasz Borek lukasz@borek.org.pl
I’ve done the same as well. It doesn’t help that smartctl doesn’t even try to have consistent output for SATA, SAS, and NVMe drives, and especially that it doesn’t enforce uniform attribute labels. Yes, the fundamental problem is that SMART is mechanism without policy, and inconsistently implemented, but smartctl doesn’t help like it could. I’m working on a post processor for derived.h to at least debulk the madness, e.g. casting all of the SSD life remaining/used metrics into the same name, and adding a primitive to subtract from 100. If upstream won’t take that addition, I guess I’ll be forking smartmoxntools in toto. I had hopes for smartctl_exporter, but have given up on that project as too disorganized and contentious. So the last time I did this, I looked up the details of all 76 drive SKUs in my fleet and hardcoded every one into my collection script. Many systems cheap out and just use the overall pass/fail SMART health status attribute, which is very prone to reporting that clearly failing drives are just smurfy, and thus worthless. This is what BMCs seem to do, for example. Grown defects - on a spinner RMA or shred it if there are say more than 1 per 2TB. SATA downshift errors, though these can be HBA issues as well. UDMA/CRC errors - silently slow, but can be addressed by reseating in most cases, and using OEM carriers for SATA/SAS drives. Rate of reallocated blocks, alert if it isn’t quite slow Since Nautilus we are much less prone to grown errors then we used to be, the OSD will retry a failed write, so a remapped LBA will succeed the second time. There is IIRC a limit to how many of these are tolerated, but it does underscore the need to look deeper. Similarly one can alert on drives with high latency via primal query. Oh we were talking about the module. I vote to remove it. Note that the RH model is binary blobs as well as the ProphetStor model. Incomplete and impossible to maintain in the current state. It would be terrific to have a fully normalized and maintained / maintainable metric and prediction subsystem, but I haven’t seen anyone step up. It would be too much for me to do myself, especially without access to hardware, and I fear that without multiple people involved we won’t have continuity and it’ll lapse again. If at least one SWE with staying power steps up I’d be willing to entertain an idea for reimplementation eschewing opaque madness. anthonydatri@Mac models % pwd /Users/anthonydatri/git/ceph/src/pybind/mgr/diskprediction_local/models anthonydatri@Mac models % file redhat/* redhat/config.json: JSON data redhat/hgst_predictor.pkl: data redhat/hgst_scaler.pkl: data redhat/seagate_predictor.pkl: data redhat/seagate_scaler.pkl: data anthonydatri@Mac models %
On Apr 8, 2025, at 5:30 AM, Lukasz Borek <lukasz@borek.org.pl> wrote:
+1
I wasn't aware that this module is obsolete and was trying to start it a few weeks ago.
We develop a home-made solution some time ago to monitor smart data from both HDD (uncorrected errors, grown defect list) and SSD (WLC/TBW). But keeping it up to date with non-unified disk models is a nightmare.
Alert : "OSD.12 is going to fail. Replace it soon" before seeing SLOW_OPS would be a game changer!
Thanks!
On Tue, 8 Apr 2025 at 10:00, Michal Strnad <michal.strnad@cesnet.cz> wrote:
Hi.
From our point of view, it's important to keep disk failure prediction tool as part of Ceph, ideally as an MGR module. In environments with hundreds or thousands of disks, it's crucial to know whether, for example, a significant number of them are likely to fail within a month - which, in the best-case scenario, would mean performance degradation, and in the worst-case, data loss.
Some have already responded to the deprecation of diskprediction by starting to develop their own solutions. For instance, just yesterday, Daniel Persson published a solution [1] on his website that addresses the same problem.
Would it be possible to join forces and try to revive that module?
[1] https://www.youtube.com/watch?v=Gr_GtC9dcMQ
Thanks, Michal
Hi everyone,
On today's Ceph Steering Committee call we discussed the idea of removing the diskprediction_local mgr module, as the current prediction model is obsolete and not maintained.
We would like to gather feedback from the community about the usage of
On 4/8/25 01:18, Yaarit Hatuka wrote: this
module, and find out if anyone is interested in maintaining it.
Thanks, Yaarit _______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
_______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
-- Łukasz Borek lukasz@borek.org.pl _______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
Hi, Am 4/8/25 um 14:30 schrieb Anthony D'Atri:
anthonydatri@Mac models % pwd /Users/anthonydatri/git/ceph/src/pybind/mgr/diskprediction_local/models anthonydatri@Mac models % file redhat/* redhat/config.json: JSON data redhat/hgst_predictor.pkl: data redhat/hgst_scaler.pkl: data redhat/seagate_predictor.pkl: data redhat/seagate_scaler.pkl: data anthonydatri@Mac models %
These are Python pickle files from 2019 containing ML models made with a version of sklearn from 2019. It really looks like this part of the Ceph project is dead. Regards -- Robert Sander Linux Consultant Heinlein Consulting GmbH Schwedter Str. 8/9b, 10119 Berlin https://www.heinlein-support.de Tel: +49 30 405051 - 0 Fax: +49 30 405051 - 19 Amtsgericht Berlin-Charlottenburg - HRB 220009 B Geschäftsführer: Peer Heinlein - Sitz: Berlin
anthonydatri@Mac models % pwd /Users/anthonydatri/git/ceph/src/pybind/mgr/diskprediction_local/models anthonydatri@Mac models % file redhat/* redhat/config.json: JSON data redhat/hgst_predictor.pkl: data redhat/hgst_scaler.pkl: data redhat/seagate_predictor.pkl: data redhat/seagate_scaler.pkl: data anthonydatri@Mac models %
These are Python pickle files from 2019 containing ML models made with a version of sklearn from 2019.
Leerer Blick IMHO binaries don’t belong in git repositories and the approach kinda sounds like trying to be clever and trendy for the sake of being clever and trendy. Cf. the KISS principle. By which I mean keeping it simple, not lip-syncing when you should have retired in the 1990s. I’ve had good luck in the past with an (admittedly ugly) SMART collector that dumped harmonized metrics into the textfile_collector directory for node_exporter to pick up, then using conventional Alertmanager rules, which are easy to write, improve, and tweak for local conditions. If kept as a Manager module I could see this being yet another thing hampering scalability. Were we to implement a framework for normalizing metrics for given drive models — and honestly that’s what it takes to be useful — the community could PR the individual SKU entries over time. I would draw a line in the sand up front: no client SKUs will be accepted, no USB/Thunderbolt drives, no HBA/SAN mirages. Only physical, enterprise drive SKUs. Client drive failures are trivially predicted as simply SOON.
Hi.
From our point of view, it's important to keep disk failure prediction tool as part of Ceph, ideally as an MGR module
. In environments with hundreds or thousands of disks, it's crucial to know whether, for example, a significant number of them are likely to fail within a month - which, in the best-case scenario, would mean performance degradation, and in the worst-case, data loss.
Agreed, but the current implementation does not achieve this.
Some have already responded to the deprecation of diskprediction by starting to develop their own solutions. For instance, just yesterday, Daniel Persson published a solution [1]
Videos and costumes aren’t solutions.
on his website that addresses the same problem.
Would it be possible to join forces
Are you volunteering to code? Can you sign up to be involved going forward? Ceph has suffered time and again from something being partly implemented, only to have the sole proponent wander away.
and try to revive that module?
It really needs to be reimplemented in a less opaque way so that admins can contribute and tweak. No binary blobs.
[1] https://www.youtube.com/watch?v=Gr_GtC9dcMQ
Thanks, Michal
On 4/8/25 01:18, Yaarit Hatuka wrote:
Hi everyone, On today's Ceph Steering Committee call we discussed the idea of removing the diskprediction_local mgr module, as the current prediction model is obsolete and not maintained. We would like to gather feedback from the community about the usage of this module, and find out if anyone is interested in maintaining it. Thanks, Yaarit _______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
_______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
Hello, I would like vote against remove diskprediction module from CEPH. Sincerely Jan Marek Dne út, dub 08, 2025 at 09:59:34 CEST napsal(a) Michal Strnad:
Hi.
From our point of view, it's important to keep disk failure prediction tool as part of Ceph, ideally as an MGR module. In environments with hundreds or thousands of disks, it's crucial to know whether, for example, a significant number of them are likely to fail within a month - which, in the best-case scenario, would mean performance degradation, and in the worst-case, data loss.
Some have already responded to the deprecation of diskprediction by starting to develop their own solutions. For instance, just yesterday, Daniel Persson published a solution [1] on his website that addresses the same problem.
Would it be possible to join forces and try to revive that module?
[1] https://www.youtube.com/watch?v=Gr_GtC9dcMQ
Thanks, Michal
On 4/8/25 01:18, Yaarit Hatuka wrote:
Hi everyone,
On today's Ceph Steering Committee call we discussed the idea of removing the diskprediction_local mgr module, as the current prediction model is obsolete and not maintained.
We would like to gather feedback from the community about the usage of this module, and find out if anyone is interested in maintaining it.
Thanks, Yaarit _______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
_______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
-- Ing. Jan Marek University of South Bohemia Academic Computer Centre Phone: +420389032080 http://www.gnu.org/philosophy/no-word-attachments.cs.html
Hi, It's will be very nice, if this module will be removed. Everything that Ceph operator need can be covered via smartctl_exporter [1] Thanks, k [1] https://github.com/prometheus-community/smartctl_exporter Sent from my iPhone
On 8 Apr 2025, at 02:20, Yaarit Hatuka <yhatuka@redhat.com> wrote:
We would like to gather feedback from the community about the usage of this module, and find out if anyone is interested in maintaining it.
Unless something has changed with smartctl_exporter, there wasn’t working support for drives behind a RAID HBA. There was when I looked the potential for harmonizing metrics, though necessarily by editing golang code and recompiling.
On Apr 9, 2025, at 2:34 AM, Konstantin Shalygin <k0ste@k0ste.ru> wrote:
Hi,
It's will be very nice, if this module will be removed. Everything that Ceph operator need can be covered via smartctl_exporter [1]
Thanks, k [1] https://github.com/prometheus-community/smartctl_exporter
Sent from my iPhone
On 8 Apr 2025, at 02:20, Yaarit Hatuka <yhatuka@redhat.com> wrote:
We would like to gather feedback from the community about the usage of this module, and find out if anyone is interested in maintaining it.
ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-leave@ceph.io
Hi, You can always consult with Releases page [1] Thanks, k [1] https://github.com/prometheus-community/smartctl_exporter/releases Sent from my iPhone
On 9 Apr 2025, at 17:51, Anthony D'Atri <anthony.datri@gmail.com> wrote:
Unless something has changed with smartctl_exporter, there wasn’t working support for drives behind a RAID HBA. There was when I looked the potential for harmonizing metrics, though necessarily by editing golang code and recompiling.
Lots of things anyone can do. Note my participation in the referenced #205 over a year ago. At the time it wasn’t going anywhere, after months of quibbling. If there is finally code there that supports multiple occulting HBAs, a mixture of native, passed-through, and occulted drives without manual per-node configuration, then that’s a terrific improvement. The normalization factor however remains.
On Apr 9, 2025, at 12:12 PM, Konstantin Shalygin <k0ste@k0ste.ru> wrote:
Hi,
You can always consult with Releases page [1]
Thanks, k
[1] https://github.com/prometheus-community/smartctl_exporter/releases
Sent from my iPhone
On 9 Apr 2025, at 17:51, Anthony D'Atri <anthony.datri@gmail.com> wrote:
Unless something has changed with smartctl_exporter, there wasn’t working support for drives behind a RAID HBA. There was when I looked the potential for harmonizing metrics, though necessarily by editing golang code and recompiling.
Dev mailing list -- dev@ceph.io To unsubscribe send an email to dev-leave@ceph.io
participants (7)
-
Anthony D'Atri
-
Jan Marek
-
Konstantin Shalygin
-
Lukasz Borek
-
Michal Strnad
-
Robert Sander
-
Yaarit Hatuka